Closed
Bug 901117
Opened 11 years ago
Closed 11 years ago
Platform touch fluffing needs the ability to weed out body event listeners
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: wesj, Assigned: wesj)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
I turned on the platform event fluffing for Android today and noticed we don't seem to be doing much fluffing on google.com. Some logging showed that we're finding event listeners on the html element itself (maybe those come from document.addEventListener?)
In Fennec's current code base, we actually ignore the body/html elements unless we're actually looking at fluffed out targets. Not when we're just deciding whether or not its worth it to fluff out the current target.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 785281 [details] [diff] [review]
Patch v1
Need to clean this up a bit. Does it seem reasonable tn?
Attachment #785281 -
Flags: feedback?(tnikkel)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 785281 [details] [diff] [review]
Patch v1
If this is what we are doing on Fennec then this seems reasonable.
Attachment #785281 -
Flags: feedback?(tnikkel) → feedback+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Made this a bit more general. Running this on try (with this feature turned on for Android):
https://hg.mozilla.org/try/rev/f0b3ece1f3d5
Attachment #785281 -
Attachment is obsolete: true
Attachment #785815 -
Flags: review?(tnikkel)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 785815 [details] [diff] [review]
touch3
So now both IsElementClickable stop at the body tag? The first patch just had one. Why the change?
|
|
Assignee | |
Comment 6•11 years ago
|
||
Don't know where I lost that, but yes, we only really want this on our initial check.
Attachment #785815 -
Attachment is obsolete: true
Attachment #785815 -
Flags: review?(tnikkel)
Attachment #785832 -
Flags: review?(tnikkel)
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 785832 [details] [diff] [review]
Patch
I would make stopAt default to nullptr.
Attachment #785832 -
Flags: review?(tnikkel) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
|
||
Comment 9•11 years ago
|
||
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•