Closed
Bug 901284
Opened 11 years ago
Closed 11 years ago
Enable GamePad API in the webapp runtime
Categories
(Firefox Graveyard :: Webapp Runtime, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: marco, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review-
|
Details | Diff | Splinter Review |
Do we only need a pref? Can web pages use this API without asking for permissions?
Attachment #785462 -
Flags: review?(ted)
Comment 1•11 years ago
|
||
Comment on attachment 785462 [details] [diff] [review]
enable_gamepad_api
Review of attachment 785462 [details] [diff] [review]:
-----------------------------------------------------------------
We're not shipping this enabled-by-default on our release yet, so we should do the same thing for the webapp runtime:
http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js#92
There are no permissions involved, we just don't send information about Gamepads to windows unless the user interacts with a Gamepad while the window is visible.
Attachment #785462 -
Flags: review?(ted) → review-
Reporter | ||
Comment 2•11 years ago
|
||
Is there something I can do to help landing this feature for Firefox 26?
Comment 3•11 years ago
|
||
I have a few spec API concerns, I think I enumerated them in bug 878828. I'd like to get them sorted out before enabling by default.
Comment 4•11 years ago
|
||
Yup, we're happy to have the API be automatically enabled in the runtime as soon as it's enabled in the platform, but we won't enable it in the runtime specifically.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Reporter | ||
Comment 5•11 years ago
|
||
I guess we'll still need to set the pref when the time will come.
Comment 6•11 years ago
|
||
Can you not do what we do in all.js for now and #ifdef it so it's enabled for nightly builds?
Comment 7•11 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #5)
> I guess we'll still need to set the pref when the time will come.
That depends. If the feature is enabled by twiddling the platform pref, then it'll get enabled in the runtime automatically. If it's enabled by overriding the platform pref with a Firefox pref, on the other hand, then we'll need to enable it in the runtime specifically, just as in Firefox. But let's burn that bridge when we come to it.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6)
> Can you not do what we do in all.js for now and #ifdef it so it's enabled
> for nightly builds?
Since all.js is a platform prefs file, it should already be enabled in nightly builds.
Comment 8•11 years ago
|
||
FYI I intend to enable the API by default in bug 878828.
Assignee | ||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•