Closed
Bug 901489
Opened 11 years ago
Closed 11 years ago
[bb][refactor] Confirm
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: basiclines, Assigned: pivanov)
References
Details
Attachments
(1 file)
Use class-names based selectors to simplify the component. Split in as many files as needed (CSS) We also need to take a look again at the markup to see if there is anything to improve.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → pivanov
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #791866 -
Flags: review?(igonzaleznicolas)
Attachment #791866 -
Flags: feedback?(anthony)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 791866 [details]
PR for Gaia-UI-Building-Blocks
As soon as we merge this, i'll update `buttons.css` PR to import them in to the confirm/layout.css
Attachment #791866 -
Flags: review?(igonzaleznicolas) → review+
|
||
Updated•11 years ago
|
Attachment #791866 -
Flags: feedback?(anthony) → feedback-
Nice work Pavel!
I don't like the idea of overusing flex, I think it works great in the menu but not for the whole UI, so I have created a proposal based on this PR and the structure we have in the current BB.
https://github.com/rnowm/Gaia-UI-Building-Blocks/tree/confirm/style/confirm
|
|
Assignee | |
Updated•11 years ago
|
Attachment #791866 -
Flags: review?(arnau)
Attachment #791866 -
Flags: review?(arnau) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Landed in v2:
https://github.com/mozilla-b2g/Gaia-UI-Building-Blocks/commit/fa2791d012186f235e446d16e1fcd735b2ee2875
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•