Closed Bug 901578 Opened 11 years ago Closed 11 years ago

Remove mouse_event_shim.js from settings app

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Keywords: perf, Whiteboard: [c= p= s=2013.08.09 u=1.1] QARegressExclude)

Attachments

(1 file)

Github pull request pointer
(deleted), text/html
kaze
: review+
Details
Refer to bug 861735 , We'd better remove dependency of this mouse_event_shim.js for below reasons. 1. prevent hidden bug in the future. 2. improve load time and responsiveness 3. gecko already dispatch events by itself.
Attached file Github pull request pointer (deleted) —
Attachment #785814 - Flags: review?(kaze)
I did remove it 3 months ago in bug 863164. How could it come back???
(In reply to Anthony Ricaud (:rik) from comment #2) > I did remove it 3 months ago in bug 863164. How could it come back??? Ah, I guess you did the real removal of it. There were just a few bits and pieces left of it I suppose. (Looks like the library does not actually get included in the app, but does return from grep because it's commented out.) Anyway - as this is a fairly trivial removal, I'll mark you as reviewer as well since you already have eyes on this.
Comment on attachment 785814 [details] Github pull request pointer Rik - feel free to review this one as well.
Attachment #785814 - Flags: review?(anthony)
Comment on attachment 785814 [details] Github pull request pointer Sorry, I can't decently review this after what I said in the gaia meeting yesterday :) Only module owners or peers should do that.
Attachment #785814 - Flags: review?(anthony)
Comment on attachment 785814 [details] Github pull request pointer r+ if this bug becomes leo+ (i.e. if we want to uplift this to v1-train). If leo-, then we should remove the polyfill completely instead of fixing it.
blocking-b2g: --- → leo?
Hi Kaze, Once all meta bugs of 861735 are addressed, we will track removal of the polyfill in the main bug (861735).
blocking-b2g: leo? → leo+
Keywords: perf
OS: Mac OS X → Gonk (Firefox OS)
Priority: -- → P1
Hardware: x86 → ARM
Whiteboard: [c= p= s= u=1.1]
As this has been approved for uplift, I assume Kaze's review stands.. Landed in master: https://github.com/mozilla-b2g/gaia/commit/d372e28b196d1662051587645732eddff9842fbf
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [c= p= s= u=1.1] → [c= p= s=2013.08.09 u=1.1]
Comment on attachment 785814 [details] Github pull request pointer (In reply to Kevin Grandon :kgrandon from comment #8) > As this has been approved for uplift, I assume Kaze's review stands.. Thanks Kevin!
Attachment #785814 - Flags: review?(kaze) → review+
Uplifted d372e28b196d1662051587645732eddff9842fbf to: v1-train: 014686f6813dc7cc8381ad2697ff0e18f7e1a26f
status-b2g18: --- → fixed
v1.1.0hd: 014686f6813dc7cc8381ad2697ff0e18f7e1a26f
status-b2g-v1.1hd: --- → fixed
Whiteboard: [c= p= s=2013.08.09 u=1.1] → [c= p= s=2013.08.09 u=1.1] QARegressExclude
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: