Closed
Bug 901682
Opened 11 years ago
Closed 11 years ago
nsIXMLHttpRequest may need IID revved
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: bajaj, Assigned: bzbarsky)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
(deleted),
patch
|
Gavin
:
review+
bajaj
:
approval-mozilla-aurora+
bajaj
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
In the process of identifying https://bugzilla.mozilla.org/show_bug.cgi?id=901590, we found this may need IID revved.
Based on my lookup in hg looks like this file was last touched due to :
hg log content/base/public/nsIXMLHttpRequest.idl
changeset: 146411:708f6cd81acb
user: James Kitchener <jkitch.bug@gmail.com>
date: Thu Jun 13 01:20:10 2013 -0400
summary: Bug 796850 - Change XMLHttpRequest interface to support ByteString r=bz
Hence ccing folks who can help.
Please note this needs to be resolved before firefox 24 Beta1 goes to build today.
Comment 1•11 years ago
|
||
That patch changed nsIXMLHttpRequestEventTarget and revved the IID on it. Perhaps the script. Perhaps the script gets confused by multiple interfaces defined in one idl file?
If you rev nsIXMLHttpRequestEventTarget the things that inherit from it need to be changed too.
Comment 3•11 years ago
|
||
The patch changed nsIXMLHttpRequest and updated the uuid of nsIXMLHttpRequestEventTarget
Comment 4•11 years ago
|
||
Oh, you're right. I misread the patch =(
Comment 5•11 years ago
|
||
(In reply to David Zbarsky (:dzbarsky) from comment #1)
> That patch changed nsIXMLHttpRequestEventTarget and revved the IID on it.
> Perhaps the script. Perhaps the script gets confused by multiple interfaces
> defined in one idl file?
While it looks like comments 3 and 4 established this isn't the case here, it is entirely possible that the script can get confused from time to time. As such, I'd like to put a plug in to assist in development of the script:
https://github.com/jwir3/checkiid
Please feel free to submit pull requests if you find something wrong with it, or you think that a feature should be added to support more complicated cases.
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #786082 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → bzbarsky
Updated•11 years ago
|
Attachment #786082 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #786082 -
Flags: approval-mozilla-beta?
Attachment #786082 -
Flags: approval-mozilla-aurora?
Reporter | ||
Updated•11 years ago
|
Attachment #786082 -
Flags: approval-mozilla-beta?
Attachment #786082 -
Flags: approval-mozilla-beta+
Attachment #786082 -
Flags: approval-mozilla-aurora?
Attachment #786082 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assuming no QA needed here. Please remove [qa-] from the whiteboard and add the verifyme keyword if this needs QA.
Whiteboard: [qa-]
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•