Rudy Lu [:rudyl] (inactive after 2015/7/3) Reporter
	Description • 11 years ago

The latest version IME WebAPI is here,
https://wiki.mozilla.org/Talk:WebAPI/KeboardIME

We would need Gecko to send mozChromeEvent to notify Gaia keyboard manager (in System app) so that it could launch the keyboard app in the new IME framework.

This is to minimize the "manager" part of the IME WebAPI to only the methods that should be exposed to keyboard (IME) apps.

	Jan Jongboom [:janjongboom] (inactive) Assignee
	Comment 1 • 11 years ago

This implements the chrome events as described in https://wiki.mozilla.org/Talk:WebAPI/KeboardIME. We can't pass the whole inputcontext object through, so based on discussion with :RudyL we only pass in inputType which should be enough for the keyboard manager.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Reporter
	Comment 2 • 11 years ago

Comment on attachment 787399 [details] [diff] [review]
902830.diff

I would suggest we slightly change the event type as follows,
http://mzl.la/13PBy3L

And I'd like to ask for Yuan's help to review this.

	Jan Jongboom [:janjongboom] (inactive) Assignee
	Comment 3 • 11 years ago

Makes sense, I'll await Yuans review and change the names afterwards.

	Yuan Xulei [:yxl] (Leave from May 18)
	Comment 4 • 11 years ago

Comment on attachment 787399 [details] [diff] [review]
902830.diff

Review of attachment 787399 [details] [diff] [review]:
-----------------------------------------------------------------

I give r=-.
The `focus change` event should be simply sent from forms.js to the system app without going through navigator.mozInputMethod and Keyboard.jsm. With this patch, the system app may received two same events, one from the navigator of systema app and the other from the navigator of keyboard app.

	Jan Jongboom [:janjongboom] (inactive) Assignee
	Comment 5 • 11 years ago

True, sorry, I was caught up in trying to pass inputcontext through, which doesn't make sense in this case :-)

	Jan Jongboom [:janjongboom] (inactive) Assignee
	Comment 8 • 11 years ago

Comment on attachment 787429 [details] [diff] [review]
902830_v2.diff

This patch will emit the chrome event directly when receiving a message from forms.js. All communication between forms.js, Keyboard and Chrome code is in keyboard.jsm so I have put it here as well.

	Yuan Xulei [:yxl] (Leave from May 18)
	Comment 9 • 11 years ago

Comment on attachment 787428 [details] [diff] [review]
902830_v2.diff

Review of attachment 787428 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. The patch is quite clear and straightforward.

::: b2g/components/Keyboard.jsm
@@ +164,5 @@
>    },
>  
> +  handleFocusChange: function keyboardHandleFocusChange(msg) {
> +    dump('~Keyboard.jsm handleFocusChange\n')
> +    dump(JSON.stringify(msg.data) + '\n');

nit: remove logs only for debug.

	Jan Jongboom [:janjongboom] (inactive) Assignee
	Comment 10 • 11 years ago

Jan Jongboom <janjongboom@gmail.com>
Bug 902830 - Emit chrome event when input focus change happens. r=yxl

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 11 years ago

applying 902830
patching file b2g/components/Keyboard.jsm
bad hunk #2 @@ -158,16 +158,35 @@ let Keyboard = {
 (24 16 35 35)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 902830

Also, please generate patches with the metadata needed for checkin. It makes life much easier for people like myself trying to land them on your behalf.
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

	Yuan Xulei [:yxl] (Leave from May 18)
	Comment 12 • 11 years ago

Jan, do you need help with regenerating the patch?

	Jan Jongboom [:janjongboom] (inactive) Assignee
	Comment 13 • 11 years ago

Rebased the patch + added commit info

	Yuan Xulei [:yxl] (Leave from May 18)
	Comment 14 • 11 years ago

Jan, thanks for the patch. It's ready to land and add checkin-needed keyword.

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 11 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/a05dfe36c4de

	Ryan VanderMeulen [:RyanVM]
	Comment 16 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/a05dfe36c4de