Closed
Bug 902934
Opened 11 years ago
Closed 11 years ago
Permanent Orange: TEST-UNEXPECTED-FAIL | test_attachment_size.js | logHelper.js | Error console says [stackFrame gApp is not defined
Categories
(MailNews Core :: Testing Infrastructure, defect)
MailNews Core
Testing Infrastructure
Tracking
(thunderbird24 fixed, thunderbird25 fixed)
RESOLVED
FIXED
Thunderbird 26.0
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jcranmer
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Seen since we've been fixing the permanent oranges:
https://tbpl.mozilla.org/php/getParsedLog.php?id=26225091&tree=Thunderbird-Beta#error29
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/mime/test/unit/test_attachment_size.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame gApp is not defined] - See following stack:
JS frame :: ../../../resources/logHelper.js :: _errorConsoleTunnel.observe :: line 63
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
TEST-INFO | (xpcshell/head.js) | exiting test
Assignee | ||
Comment 1•11 years ago
|
||
I think this should fix it. If the blocklist service wants an nsIXULAppInfo in xpcshell tests, then we have to give it one - xpcshell doesn't have a nsIXULAppInfo component.
Whilst here, I'm taking the opportunity to clean up our other nsIXULAppInfo uses to use that nice generic testing module that someone provided.
I've got this running off try server from a comm-beta push:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=6c74575c00ac
Assignee | ||
Updated•11 years ago
|
Keywords: intermittent-failure
Assignee | ||
Comment 2•11 years ago
|
||
This time with the needed head_steel.js file and a new Try server spin:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=7394bd8280ea
Attachment #787579 -
Attachment is obsolete: true
Attachment #787579 -
Flags: review?(Pidgeot18)
Attachment #787708 -
Flags: review?(Pidgeot18)
Updated•11 years ago
|
Attachment #787708 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 787708 [details] [diff] [review]
The fix v2
[Triage Comment]
This passed on try, so taking straight onto the branches.
Attachment #787708 -
Flags: approval-comm-beta+
Attachment #787708 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/acbc0c79daa4
https://hg.mozilla.org/releases/comm-beta/rev/a010b1ae5f5d
status-thunderbird24:
--- → fixed
status-thunderbird25:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•