Closed Bug 902934 Opened 11 years ago Closed 11 years ago

Permanent Orange: TEST-UNEXPECTED-FAIL | test_attachment_size.js | logHelper.js | Error console says [stackFrame gApp is not defined

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(thunderbird24 fixed, thunderbird25 fixed)

RESOLVED FIXED
Thunderbird 26.0
Tracking Status
thunderbird24 --- fixed
thunderbird25 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Seen since we've been fixing the permanent oranges: https://tbpl.mozilla.org/php/getParsedLog.php?id=26225091&tree=Thunderbird-Beta#error29 TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/mailnews/mime/test/unit/test_attachment_size.js | test failed (with xpcshell return code: 0), see following log: TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame gApp is not defined] - See following stack: JS frame :: ../../../resources/logHelper.js :: _errorConsoleTunnel.observe :: line 63 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 TEST-INFO | (xpcshell/head.js) | exiting test
Attached patch The fix (obsolete) (deleted) — Splinter Review
I think this should fix it. If the blocklist service wants an nsIXULAppInfo in xpcshell tests, then we have to give it one - xpcshell doesn't have a nsIXULAppInfo component. Whilst here, I'm taking the opportunity to clean up our other nsIXULAppInfo uses to use that nice generic testing module that someone provided. I've got this running off try server from a comm-beta push: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=6c74575c00ac
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #787579 - Flags: review?(Pidgeot18)
Blocks: 896738
Attached patch The fix v2 (deleted) — Splinter Review
This time with the needed head_steel.js file and a new Try server spin: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=7394bd8280ea
Attachment #787579 - Attachment is obsolete: true
Attachment #787579 - Flags: review?(Pidgeot18)
Attachment #787708 - Flags: review?(Pidgeot18)
Attachment #787708 - Flags: review?(Pidgeot18) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
Comment on attachment 787708 [details] [diff] [review] The fix v2 [Triage Comment] This passed on try, so taking straight onto the branches.
Attachment #787708 - Flags: approval-comm-beta+
Attachment #787708 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: