Closed
Bug 903166
Opened 11 years ago
Closed 10 years ago
Add "layout_type" to featured apps API endpoint when collection_type="basic" and collection_type="operator"
Categories
(Marketplace Graveyard :: API, defect, P4)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: cvan, Unassigned)
References
Details
https://github.com/mozilla/flue/blob/master/defaults.py#L209-L211
https://flue.paas.allizom.org/api/v1/fireplace/search/featured/
For curated collections (collection_type=basic), there are two additional values that the Publishing Tool can collect:
1. layout_type - a value that gets added as a CSS `class` to determine the visual style of the collection
2. icon - an absolute path to an icon that gets centred in the collection - e.g., http://f.cl.ly/items/3d310s2T3L0q2V0f3w47/Screen%20Shot%202013-08-08%20at%203.38.13%20PM.png
Reporter | ||
Updated•11 years ago
|
Summary: Add "layout_type" and "icon" to featured apps API endpoint when collection_type="basic" → Add "layout_type" and "icon" to featured apps API endpoint when collection_type="basic" and collection_type="operator"
Updated•11 years ago
|
Priority: -- → P2
Reporter | ||
Comment 1•11 years ago
|
||
Basta, we should also add background-color + text color to the Curation Tool UI.
Comment 2•11 years ago
|
||
<input type="color">, how doth Firefox disrespect thee
Comment 3•11 years ago
|
||
BG color and text color have been added, although they're a bit hairy on the New Collection page :-/
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Matt Basta [:basta] from comment #2)
> <input type="color">, how doth Firefox disrespect thee
Yeah... bug 547004...
Here's what I did in AMO...
https://github.com/mozilla/zamboni/blob/master/media/js/impala/persona_creation.js#L325-L335
https://github.com/mozilla/zamboni/blob/master/media/js/lib/jquery.minicolors.js
Reporter | ||
Comment 5•11 years ago
|
||
Davor, can we forgo this? Let us know!
Flags: needinfo?(dspasovski)
Priority: P2 → P4
Summary: Add "layout_type" and "icon" to featured apps API endpoint when collection_type="basic" and collection_type="operator" → Add "layout_type" to featured apps API endpoint when collection_type="basic" and collection_type="operator"
Comment 6•11 years ago
|
||
Icon is now image and layout type isn't needed for v1.
Updated•11 years ago
|
Flags: needinfo?(dspasovski)
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•