+++ This bug was initially created as a clone of Bug #902380 +++ This is an interesting case we found in bug 902380. Device lost voice service but have data service. In this situation, Gaia may get a strange result for signal and voice state, voice service is not registered but has signal information. 08-07 13:50:53.001 I/Gecko ( 404): -*- RILContentHelper: Received message 'RIL:VoiceInfoChanged': {"clientId":0,"data":{"connected":false,"emergencyCallsOnly":true,"roaming":false,"network":null,"cell":null,"type":null,"signalStrength":-101,"relSignalStrength":36,"state":"searching"}}

Comment on attachment 788785 [details] [diff] [review] Part 1: Have a consistent information for signal and registration status, v2 Review of attachment 788785 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/RadioInterfaceLayer.js @@ +764,5 @@ > /** > + * A utility function to compare objects. The srcInfo may contain > + * 'rilMessageType', should ignore it. > + */ > + infoChanged: function infoChanged(srcInfo, destInfo) { Can we rename it isInfoChanged()? ::: dom/system/gonk/ril_worker.js @@ +1614,1 @@ > }, Do we still need [1]? [1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#3328

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #4) > Comment on attachment 788785 [details] [diff] [review] > Part 1: Have a consistent information for signal and registration status, v2 > > Review of attachment 788785 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/system/gonk/RadioInterfaceLayer.js > @@ +764,5 @@ > > /** > > + * A utility function to compare objects. The srcInfo may contain > > + * 'rilMessageType', should ignore it. > > + */ > > + infoChanged: function infoChanged(srcInfo, destInfo) { > > Can we rename it isInfoChanged()? Yes, isInfoChanged seems more clear to me. > > ::: dom/system/gonk/ril_worker.js > @@ +1614,1 @@ > > }, > > Do we still need [1]? > [1] is redundant, |getSignalStrength()| was called in |requestNetworkInfo()| already. Thanks for catching this. > [1] > http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker. > js#3328 I will address above comments in next version.

Comment on attachment 788786 [details] [diff] [review] Part 2: Marionette tests for signal when registration status changes, v1 Review of attachment 788786 [details] [diff] [review]: ----------------------------------------------------------------- Thank you.

Address review comment #4.

Comment on attachment 790050 [details] [diff] [review] Part 1: Have a consistent information for signal and registration status, v3 Review of attachment 790050 [details] [diff] [review]: ----------------------------------------------------------------- Perfect!

Comment on attachment 790072 [details] [diff] [review] Part 2: Marionette tests for signal when registration status changes, v1, r=hsinyi Add bug number in title.

try server: https://tbpl.mozilla.org/?tree=Try&rev=d885e42e2965

Rebase

https://hg.mozilla.org/integration/b2g-inbound/rev/e39003701964 https://hg.mozilla.org/integration/b2g-inbound/rev/d42114d05d10

https://hg.mozilla.org/mozilla-central/rev/e39003701964 https://hg.mozilla.org/mozilla-central/rev/d42114d05d10

Removing koi? since this is in gecko 26 which will be the basis for Firefox OS 1.2.