Closed Bug 903293 Opened 11 years ago Closed 11 years ago

Remote browser constructors shouldn't try to initialize session history

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file)

When creating a <browser remote=true> element and injecting it, the constructor tries to initialize session history without having a docShell. As this is used by the background thumbnailing service this errors appears quite regularly.
Component: General → XUL Widgets
Product: Firefox → Toolkit
Comment on attachment 787973 [details] [diff] [review] Remote browser constructors shouldn't try to initialize session history I wonder if this.isRemoteBrowser should be used to better convey the intention?
Comment on attachment 787973 [details] [diff] [review] Remote browser constructors shouldn't try to initialize session history Review of attachment 787973 [details] [diff] [review]: ----------------------------------------------------------------- I think (though not certain yet) that we might remove the isRemoteBrowser in the future (because everything related to a remote browser should be in remote-browser.xml), so using docShell here is fine
Attachment #787973 - Flags: review?(felipc) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
One thing I was curious about was how session history works in remote browsers, if it isn't set up here. Anyone know? :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: