Closed
Bug 903293
Opened 11 years ago
Closed 11 years ago
Remote browser constructors shouldn't try to initialize session history
Categories
(Toolkit :: XUL Widgets, defect)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
When creating a <browser remote=true> element and injecting it, the constructor tries to initialize session history without having a docShell. As this is used by the background thumbnailing service this errors appears quite regularly.
Assignee | ||
Updated•11 years ago
|
Component: General → XUL Widgets
Product: Firefox → Toolkit
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #787973 -
Flags: review?(felipc)
Comment 2•11 years ago
|
||
Comment on attachment 787973 [details] [diff] [review]
Remote browser constructors shouldn't try to initialize session history
I wonder if this.isRemoteBrowser should be used to better convey the intention?
Comment 3•11 years ago
|
||
Comment on attachment 787973 [details] [diff] [review]
Remote browser constructors shouldn't try to initialize session history
Review of attachment 787973 [details] [diff] [review]:
-----------------------------------------------------------------
I think (though not certain yet) that we might remove the isRemoteBrowser in the future (because everything related to a remote browser should be in remote-browser.xml), so using docShell here is fine
Attachment #787973 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment 6•11 years ago
|
||
One thing I was curious about was how session history works in remote browsers, if it isn't set up here. Anyone know? :)
You need to log in
before you can comment on or make changes to this bug.
Description
•