Closed
Bug 903300
Opened 11 years ago
Closed 8 years ago
[Messages] Implement a better resend mechanism
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect, P2)
Firefox OS Graveyard
Gaia::SMS
Tracking
(tracking-b2g:backlog)
RESOLVED
WONTFIX
tracking-b2g | backlog |
People
(Reporter: lecky.wanglei, Unassigned)
References
Details
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; aff-kingsoft-ciba; Zune 4.7)
Steps to reproduce:
1.there is a failed mms,click to resend it
2.reboot the phone immediately
3.open the previous message thread
Actual results:
there are two same failed mms in it
Expected results:
i think there should be one failed mms in it
We are able to reproduce this issue on build below.
The MMS is sent when no signal/ Airplane Mode is on, then the user restarts the phone and gets an immediate fail to send when the device starts back up. Then the user tries to send the mms again and restarts the phone cause a duplicate picture to display.
Leo Build ID: 20130904041204
Base: V10a
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/307824edadd7
Gaia: d0a415bbf23e5d01c2b287d9fca708e167cfe70d
Platform Version: 18.1
I am not sure what the QAwanted is looking for, but let me know if you need any more investigation into this issue. We do not have Helix devices so we cannot test that.
QA Contact: dwatson
Comment 2•11 years ago
|
||
That's good enough - that tells us this is reproducible on leo, which means this is not a device-specific issue. HD issues are only supposed to target resolution problems, general 1.1 issues go to leo. So moving to leo?
blocking-b2g: hd? → leo?
Keywords: qawanted
Updated•11 years ago
|
Component: General → Gaia::SMS
hi,preeti,
do you mean that the issue will not be fixed on V1.1,
how about V1.2?
Comment 5•11 years ago
|
||
A legacy bug. Marked it as "NEW".
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 6•11 years ago
|
||
The current behavior is done like this:
* first we try to send again the message
* when we get a success or a failure, we delete the previous failed message
This code path ensures us that we _do_ still have the message if we reboot the phone while the MMS is sending. If we'd delete it before hand, we would lose the message.
The only alternative is to have a gecko method "resend" that would take a message id, and could therefore reuse the existing message instead of creating a new one/deleting the old one.
Flagging Gene for this. This would probably make the code cleaner in Gaia, but imho this is a very minor issue othrewise.
Flags: needinfo?(gene.lian)
Updated•11 years ago
|
Severity: blocker → normal
Updated•11 years ago
|
Updated•11 years ago
|
Summary: [B2G][Helix][mms][zhaotao]resend a failed mms,then reboot the phone,there will be two same failed mms → [B2G][Helix][fugu][mms][zhaotao]resend a failed mms,then reboot the phone,there will be two same failed mms
the same issue with resend SMS. Not sure what is the relation with: https://bugzilla.mozilla.org/show_bug.cgi?id=896925
Comment 10•11 years ago
|
||
no need reboot phone, just re-enter the chatroom can be pro this issue.
in code just find save operation inside Send function both in sendSMS and sendMMS whatever resend or 1st send
Updated•11 years ago
|
Summary: [B2G][Helix][fugu][mms][zhaotao]resend a failed mms,then reboot the phone,there will be two same failed mms → [B2G][Helix][fugu][mms][zhaotao][tarako]resend a failed mms,then reboot the phone,there will be two same failed mms
Comment 11•11 years ago
|
||
bug 896925 is the bug that made us implement what you see here.
I prefer to have the same message twice than losing it ;)
(In reply to siiaceon from comment #10)
> no need reboot phone, just re-enter the chatroom can be pro this issue.
Except it will be eventually removed when the other message is sent. Maybe we can do something for this specific case though, when we'll start having a local db in Gaia (should happen this year).
Comment 12•11 years ago
|
||
Gene isn't working on this bug.
Assignee: gene.lian → nobody
blocking-b2g: - → backlog
Assignee | ||
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
Updated•9 years ago
|
Depends on: sms-db-in-gaia
Comment 13•9 years ago
|
||
(In reply to Julien Wajsberg [:julienw] (PTO -> 2016) from comment #6)
> The current behavior is done like this:
> * first we try to send again the message
> * when we get a success or a failure, we delete the previous failed message
>
> This code path ensures us that we _do_ still have the message if we reboot
> the phone while the MMS is sending. If we'd delete it before hand, we would
> lose the message.
Idea: we could delete the previous message once we have the "sending" event ?
Is it possible to have an "error" event without a "sending" event ?
Thought: should we delete the previous error-ed message ? Actually I think it could be just as good to keep the previous error-ed message.
Summary: [B2G][Helix][fugu][mms][zhaotao][tarako]resend a failed mms,then reboot the phone,there will be two same failed mms → [Messages] Implement a better resend mechanism
Comment 15•8 years ago
|
||
Move to firefox project. Still, let me know if there are any UX emergency.
Flags: needinfo?(bmao)
Comment 16•8 years ago
|
||
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Comment 17•8 years ago
|
||
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in
before you can comment on or make changes to this bug.
Description
•