Closed Bug 903580 Opened 11 years ago Closed 11 years ago

[MP] Defect - Downloads button is corrupted

Categories

(Firefox for Metro Graveyard :: App Bar, defect, P2)

26 Branch
x86_64
Windows 8
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: marcia, Assigned: emtwo)

References

Details

(Whiteboard: [preview] feature=defect c=tbd u=tbd p=1)

Attachments

(2 files)

Attached image Screenshot (1).png (deleted) —
Seen while running Metro using: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 STR: 1. Install the latest nightly. 2. Observe graphic corruption on the download button in the attached screenshot.
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0
Assignee: nobody → msamuel
Hey Marina, can you provide a point estimate for this Defect.
Flags: needinfo?(msamuel)
p=1
Flags: needinfo?(msamuel)
Blocks: metrov1it13
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=1
Attached patch adjust-circular-canvas (deleted) — Splinter Review
The problem: The canvas on top of the download button is 44x44 whereas the button is 40x40 but they both had the same margin initially (margin: 0 @toolbar_horizontal_spacing@)so the canvas circle appeared to be shifted down and to the right Proposed solution: Adjust the pixels for the canvas so they are centered on top of the button. I think this is still brittle since changes to position in both the button and canvas should happen together. Open to other suggestions. Could keep this for now as a quick fix and have a better fix later?
Attachment #788371 - Flags: review?(jmathies)
Blocks: metrov1it12
No longer blocks: metrov1it13
Attachment #788371 - Flags: review?(jmathies) → review?(ally)
Comment on attachment 788371 [details] [diff] [review] adjust-circular-canvas Review of attachment 788371 [details] [diff] [review]: ----------------------------------------------------------------- please file bug for better future fix so we don't lose it.
Attachment #788371 - Flags: review?(ally) → review+
Whiteboard: [preview] feature=defect c=tbd u=tbd p=1 → [fixed-in-fx-team][preview] feature=defect c=tbd u=tbd p=1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][preview] feature=defect c=tbd u=tbd p=1 → [preview] feature=defect c=tbd u=tbd p=1
Target Milestone: --- → Firefox 26
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0 Build ID: 20130813030205 Built from http://hg.mozilla.org/mozilla-central/rev/c146d402a55f WFM Tested on windows 8 using latest nightly for iteration-12 and I didn't see any issue.
Summary: Defect - Downloads button is corrupted → [MP] Defect - Downloads button is corrupted
Went through the following "Defect" for iteration #13 without any issues. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-01-03-02-18-mozilla-central/ - Went through the original issue in comment #0 without any issues - Downloaded a linux ISO (around 1GB) and ensured that the "blue indication" graphic was smooth all the way through - Ensured that the "blue indication circle" looked graphically correct once the download has been completed (and that it also cleared and didn't say behind) - Went through the above test cases in filled view without any issues
Went through the following "Defect" for iteration #14 without any issues. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-15-03-02-08-mozilla-central/ - Went through the original test case(s) added in comment #0 without any issues - Went through the test cases(s) added in comment #8 without any issues - Went through the above test cases in full, filled view (cannot see the download progress using snapped)
Went through the following "Defect" for iteration #16 without issues. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-22-03-02-02-mozilla-central/ - Went through the original test case(s) added in comment #0 without any issues - Went through the test cases(s) added in comment #8 without any issues - Went through the above test cases in full, filled view (cannot see the download progress using snapped)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: