Closed
Bug 903580
Opened 11 years ago
Closed 11 years ago
[MP] Defect - Downloads button is corrupted
Categories
(Firefox for Metro Graveyard :: App Bar, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: marcia, Assigned: emtwo)
References
Details
(Whiteboard: [preview] feature=defect c=tbd u=tbd p=1)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
ally
:
review+
|
Details | Diff | Splinter Review |
Seen while running Metro using:
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
STR:
1. Install the latest nightly.
2. Observe graphic corruption on the download button in the attached screenshot.
Updated•11 years ago
|
Blocks: metrov1defect&change
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → msamuel
Comment 1•11 years ago
|
||
Hey Marina, can you provide a point estimate for this Defect.
Flags: needinfo?(msamuel)
Updated•11 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=1
Assignee | ||
Comment 3•11 years ago
|
||
The problem:
The canvas on top of the download button is 44x44 whereas the button is 40x40 but they both had the same margin initially (margin: 0 @toolbar_horizontal_spacing@)so the canvas circle appeared to be shifted down and to the right
Proposed solution:
Adjust the pixels for the canvas so they are centered on top of the button. I think this is still brittle since changes to position in both the button and canvas should happen together. Open to other suggestions. Could keep this for now as a quick fix and have a better fix later?
Attachment #788371 -
Flags: review?(jmathies)
Updated•11 years ago
|
Updated•11 years ago
|
Attachment #788371 -
Flags: review?(jmathies) → review?(ally)
Comment 4•11 years ago
|
||
Comment on attachment 788371 [details] [diff] [review]
adjust-circular-canvas
Review of attachment 788371 [details] [diff] [review]:
-----------------------------------------------------------------
please file bug for better future fix so we don't lose it.
Attachment #788371 -
Flags: review?(ally) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/93d88dfa06f1
And Bug 903633 for follow-up.
Assignee | ||
Updated•11 years ago
|
Whiteboard: [preview] feature=defect c=tbd u=tbd p=1 → [fixed-in-fx-team][preview] feature=defect c=tbd u=tbd p=1
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][preview] feature=defect c=tbd u=tbd p=1 → [preview] feature=defect c=tbd u=tbd p=1
Target Milestone: --- → Firefox 26
Comment 7•11 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130813030205
Built from http://hg.mozilla.org/mozilla-central/rev/c146d402a55f
WFM
Tested on windows 8 using latest nightly for iteration-12 and I didn't see any issue.
Updated•11 years ago
|
Blocks: MetroPreviewRelease
Summary: Defect - Downloads button is corrupted → [MP] Defect - Downloads button is corrupted
Comment 8•11 years ago
|
||
Went through the following "Defect" for iteration #13 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-01-03-02-18-mozilla-central/
- Went through the original issue in comment #0 without any issues
- Downloaded a linux ISO (around 1GB) and ensured that the "blue indication" graphic was smooth all the way through
- Ensured that the "blue indication circle" looked graphically correct once the download has been completed (and that it also cleared and didn't say behind)
- Went through the above test cases in filled view without any issues
Comment 9•11 years ago
|
||
Went through the following "Defect" for iteration #14 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-15-03-02-08-mozilla-central/
- Went through the original test case(s) added in comment #0 without any issues
- Went through the test cases(s) added in comment #8 without any issues
- Went through the above test cases in full, filled view (cannot see the download progress using snapped)
Comment 10•11 years ago
|
||
Went through the following "Defect" for iteration #16 without issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-22-03-02-02-mozilla-central/
- Went through the original test case(s) added in comment #0 without any issues
- Went through the test cases(s) added in comment #8 without any issues
- Went through the above test cases in full, filled view (cannot see the download progress using snapped)
You need to log in
before you can comment on or make changes to this bug.
Description
•