Closed
Bug 903801
Opened 11 years ago
Closed 11 years ago
testcompatactors.js triggers an error by adding a debuggee to a thread actor in a detached state
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: chmanchester, Assigned: fitzgen)
References
Details
Attachments
(1 file)
(deleted),
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
This was uncovered by the fix in bug 890555. As far as I can tell, this line:
http://hg.mozilla.org/mozilla-central/file/6cd6960ea7f6/toolkit/devtools/server/tests/unit/testcompatactors.js#l14 is trying to do something that isn't supported by the ThreadActor: adding a debuggee to a thread actor in a detached state.
Ideally this should be fixed ahead of landing 890555 so that we can fix the bug in head.js without disabling too many tests or causing perma-orange.
I noticed that simply removing this line removes the error and assertions in relevant test files still pass. Of course, I only looked at this briefly and this could be a red herring. Nick, would you be able to comment on how to fix this test, or if I've misunderstood the problem? Thank you.
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(nfitzgerald)
Updated•11 years ago
|
Component: Developer Tools → Developer Tools: Debugger
Comment 1•11 years ago
|
||
In 890555, we discuss the central problem: we're calling addDebuggee when no Debugger has yet been created - so it has no effect.
Assignee | ||
Comment 2•11 years ago
|
||
Let the thread actor handle its global itself.
https://tbpl.mozilla.org/?tree=Try&rev=63e17a83423a
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Attachment #789144 -
Flags: review?(past)
Flags: needinfo?(nfitzgerald)
Updated•11 years ago
|
Attachment #789144 -
Flags: review?(past) → review+
Updated•11 years ago
|
Priority: -- → P2
Assignee | ||
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 3•11 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•