Closed
Bug 904084
Opened 11 years ago
Closed 11 years ago
[b2g-voicemail] Marionette tests fail for mozVoicemail API on the emulator
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: jaoo, Assigned: vicamo)
References
Details
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
While working on bug 888593 (Move MozVoicemail to WebIDL) I've noticed the marionette tests for mozVoicemail API on the emulator are failing.
Reporter | ||
Updated•11 years ago
|
Summary: [ b2g-voicemail] Marionette tests fails for mozVoicemail API on the emulator → [b2g-voicemail] Marionette tests fail for mozVoicemail API on the emulator
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → vyang
Assignee | ||
Comment 1•11 years ago
|
||
See also bug 806138.
Assignee | ||
Comment 2•11 years ago
|
||
Bug 834160 renames nsIRILVoicemailCallback::voicemailNotification to nsIVoicemailListener::notifyStatusChanged, but RILContentHelper was not updated accordingly.
Depends on: 834160
Assignee | ||
Comment 3•11 years ago
|
||
1) Use |SpecialPowers.Cu| instead.
2) s/voicemailNotification/notifyStatusChanged/ in RILContentHelper.js
https://tbpl.mozilla.org/?tree=Try&rev=960012c31aab
Attachment #789509 -
Flags: review?(allstars.chh)
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #3)
> Created attachment 789509 [details] [diff] [review]
> patch
>
> 1) Use |SpecialPowers.Cu| instead.
> 2) s/voicemailNotification/notifyStatusChanged/ in RILContentHelper.js
Thanks for taking care of this. Once this patch get landed I'll request review for bug 888593. Does bug 888593 need a RIL peer review? Thanks!
Attachment #789509 -
Flags: review?(allstars.chh) → review+
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to José Antonio Olivera Ortega [:jaoo] (PTO August 19th till Sept 2nd) from comment #4)
> Thanks for taking care of this. Once this patch get landed I'll request
> review for bug 888593. Does bug 888593 need a RIL peer review? Thanks!
Probably not, but we'll still have a check offlinely. Thank you for the job!
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Blocks: b2g-marionette
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•