Closed Bug 904109 Opened 11 years ago Closed 11 years ago

Investigate hardcoding the default TabsInToolbar dimensions and only computing them if the font, theme, or DPI are non-default

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [Australis:P5][Australis:M?]) 

We do some computations in TabsInTitlebar._update that we suspect are the full cause for a reflow. If we hardcode these values we might be able to remove the reflow in the default case, and fall back to computing these values if the font or DPI are non-default.

Simple try push without the fallback code implemented:
https://tbpl.mozilla.org/?tree=Try&rev=551a2e2745de

Baseline:
https://tbpl.mozilla.org/?tree=UX&rev=b51d299fc3be
Needed to fix a syntax error, repushed to tryserver:
https://tbpl.mozilla.org/?tree=Try&rev=91d490e0b005
Summary: Investigate hardcoding the default TabsInToolbar dimensions and only computing them if the font or DPI are non-default → Investigate hardcoding the default TabsInToolbar dimensions and only computing them if the font, theme, or DPI are non-default
This feels like a more fragile variation of bug 897218 IMO.
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=897218
Blocks: 905695
Whiteboard: [Australis:P?][Australis:M?]
Whiteboard: [Australis:P?][Australis:M?] → [Australis:P5][Australis:M?]
I think we should WONTFIX this. Jared, do you agree?
Flags: needinfo?(jaws)
Agreed.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(jaws)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.