Closed Bug 904348 Opened 11 years ago Closed 11 years ago

[binary data] Re-enable Binary Data

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 898347

People

(Reporter: nsm, Assigned: nsm)

References

Details

Attachments

(2 files, 3 obsolete files)

Attached patch Re-enable Binary Data (obsolete) (deleted) — Splinter Review
Except let's do it with fuzzing this time. :decoder, :gkw, thanks!
Attachment #789345 - Flags: review?(nmatsakis)
Attachment #789345 - Flags: feedback?(gary)
Attachment #789345 - Flags: feedback?(choller)
Depends on: 904755
Comment on attachment 789345 [details] [diff] [review] Re-enable Binary Data new StructType({0: 0}); Assertion failure: JSID_IS_STRING(iden), at ../jsapi.h:1240 === new ArrayType(uint8, -null); Assertion failure: isInt32(), at ./dist/include/js/Value.h:1093 === gczeal(8, 1); new StructType(RegExp()); Assertion failure: fieldList, at /srv/repos/mozilla-central/js/src/builtin/BinaryData.cpp:1722
Attachment #789345 - Flags: feedback?(choller) → feedback-
Comment on attachment 789345 [details] [diff] [review] Re-enable Binary Data Clearing feedback? flag until outstanding bugs are fixed.
Attachment #789345 - Flags: feedback?(gary)
Attached patch Fuzzer fixes (obsolete) (deleted) — Splinter Review
These should fix comment 1 bugs.
Flags: needinfo?(gary)
Attachment #789345 - Attachment is obsolete: true
Attachment #789345 - Flags: review?(nmatsakis)
Comment on attachment 789859 [details] [diff] [review] Re-enable binary data, with several fixes. x = []; Object.defineProperty(x, 2, {}) Array.prototype.map.call(x, Data.prototype.update) Crashes js debug 64-bit deterministic threadsafe shell [@ js::EncapsulatedPtr]
Attachment #789859 - Flags: feedback-
Attached file stack for testcase in comment 5 (deleted) —
Flags: needinfo?(gary)
Comment on attachment 789981 [details] [diff] [review] Re-enable binary data, with several fixes. Haven't hit more problems so far :)
Attachment #789981 - Flags: feedback+
Comment on attachment 789981 [details] [diff] [review] Re-enable binary data, with several fixes. No major problems found so far either.
Attachment #789981 - Flags: feedback+
Blocks: 898347
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: