Closed Bug 904695 Opened 11 years ago Closed 11 years ago

Don't include nsReadableUtils.h in nsContentUtils.h

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Patch (v3)
(deleted), patch
jst
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch Patch (v1) (obsolete) (deleted) — — Splinter Review
The most pointless review request ever. Does what it says on the can. Whoever r+'es first wins!
Attachment #789679 - Flags: review?(khuey)
Attachment #789679 - Flags: review?(justin.lebar+bug)
Attachment #789679 - Flags: review?(Ms2ger)
You're still transitively including it.
(In reply to comment #2) > You're still transitively including it. Through which header?
nsContentUtils.h -> nsContentListDeclarations.h -> nsStringGlue.h -> nsReadableUtils.h
(In reply to comment #4) > nsContentUtils.h -> nsContentListDeclarations.h -> nsStringGlue.h -> > nsReadableUtils.h Alright.
Comment on attachment 789679 [details] [diff] [review] Patch (v1) nsContentListDeclarations.h should be able to use nsStringFwd.h, I think. Anyways as is the patch doesn't accomplish anything.
Attachment #789679 - Flags: review?(khuey)
Attachment #789679 - Flags: review?(justin.lebar+bug)
Attachment #789679 - Flags: review?(Ms2ger)
Attached patch Patch (v2) (obsolete) (deleted) — — Splinter Review
This does get the job done!
Attachment #789679 - Attachment is obsolete: true
Attachment #791415 - Flags: review?(khuey)
Comment on attachment 791415 [details] [diff] [review] Patch (v2) Review of attachment 791415 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/base/public/HTMLSplitOnSpacesTokenizer.h @@ +3,5 @@ > + * License, v. 2.0. If a copy of the MPL was not distributed with this > + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > + > +#ifndef HTMLSplitOnSpacesTokenizer_h__ > +#define HTMLSplitOnSpacesTokenizer_h__ No trailing underscores per the style guide.
(In reply to comment #8) > Comment on attachment 791415 [details] [diff] [review] > --> https://bugzilla.mozilla.org/attachment.cgi?id=791415 > Patch (v2) > > Review of attachment 791415 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: content/base/public/HTMLSplitOnSpacesTokenizer.h > @@ +3,5 @@ > > + * License, v. 2.0. If a copy of the MPL was not distributed with this > > + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > > + > > +#ifndef HTMLSplitOnSpacesTokenizer_h__ > > +#define HTMLSplitOnSpacesTokenizer_h__ > > No trailing underscores per the style guide. OK, this is the first time I'm hearing about this rule though, not sure why we have it...
Attached patch Patch (v3) (deleted) — — Splinter Review
Added the missing header, and addressed Ms2ger's nit.
Attachment #791415 - Attachment is obsolete: true
Attachment #791415 - Flags: review?(khuey)
Attachment #791453 - Flags: review?(khuey)
Comment on attachment 791453 [details] [diff] [review] Patch (v3) I'm going to delegate this one to Ms2ger.
Attachment #791453 - Flags: review?(khuey) → review?(Ms2ger)
Comment on attachment 791453 [details] [diff] [review] Patch (v3) Over to jst, since Ms2ger said he probably won't get to this before Friday, and I really don't want to spend time unbitrotting this again... :/
Attachment #791453 - Flags: review?(Ms2ger) → review?(jst)
Attachment #791453 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/541ee3eb9d8b
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: