Closed Bug 904889 Opened 11 years ago Closed 4 years ago

[Australis][Win7][hidpi] In >100%dpi, closing tab when tabbar is overflowing causes the end arrow to flicker

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: marco, Unassigned)

References

Details

(Keywords: helpwanted, perf, regression, Whiteboard: [Australis:P4-][str in comment 21])

Attachments

(1 file, 2 obsolete files)

test.avi
(deleted), video/x-msvideo
Details
Closing a tab (when you have many tabs opened) causes the overflow arrow button to flash (enabled -> disabled -> enabled -> disabled). This doesn't happen always, but is easily reproducible.
Hmm… this sounds like what I reported as #2 in bug 813802 comment 107. Perhaps we have regressed that.
Blocks: australis-tabs
Component: Tabbed Browser → Theme
Keywords: regression
Whiteboard: [Australis:P3]
If we hit the overflow case here, I suspect this hits our tab perf as well.
Blocks: australis-tabs-perf
Keywords: perf
Assignee: nobody → mnoorenberghe+bmo
Status: NEW → ASSIGNED
(In reply to Marco Castelluccio [:marco] from comment #3) > Closing a tab (when you have many tabs opened) causes the overflow arrow > button to flash (enabled -> disabled -> enabled -> disabled). > This doesn't happen always, but is easily reproducible. Marco, do you know if this is Windows-only?
Flags: needinfo?(mcastelluccio)
I can't reproduce this on either Win7 or OS X. :-(
(In reply to :Gijs Kruitbosch from comment #4) > I can't reproduce this on either Win7 or OS X. :-( ... which might mean this was fixed by bug 908796 landing?
(In reply to :Gijs Kruitbosch from comment #3) > (In reply to Marco Castelluccio [:marco] from comment #3) > > Closing a tab (when you have many tabs opened) causes the overflow arrow > > button to flash (enabled -> disabled -> enabled -> disabled). > > This doesn't happen always, but is easily reproducible. > > Marco, do you know if this is Windows-only? I can't reproduce on Linux. I'll try again on Windows later.
Flags: needinfo?(mcastelluccio)
=> WFM for now
Assignee: mnoorenberghe+bmo → nobody
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
It doesn't always happen, but I can still reproduce on Windows.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
I think the difference between Windows and Linux that causes this bug is that on Windows the overflow button is activated when I open a new tab. The rightmost part of the tab is hidden behind the overflow button and I can click the button to show the remaining part of the tab.
Attached image How it is (obsolete) (deleted) —
Attachment #812339 - Attachment is patch: false
Attachment #812339 - Attachment mime type: text/plain → image/png
Attached image How it should be (obsolete) (deleted) —
At least, this is how it is on Linux.
I suspect this is fixed by bug 875180. Marco, can you verify this on tomorrow's (Oct. 23) nightly?
Flags: needinfo?(mar.castelluccio)
This seems to be fixed on Windows, indeed.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: needinfo?(mar.castelluccio)
Resolution: --- → WORKSFORME
I can't reproduce the problem of the screenshot, the tabs aren't opened halfway anymore. But I can still reproduce the button flashing.
(In reply to Marco Castelluccio [:marco] from comment #14) > I can't reproduce the problem of the screenshot, the tabs aren't opened > halfway anymore. > But I can still reproduce the button flashing. You mean it's on briefly as the new tab goes into view, and then is disabled again? That happens on Nightly too...
(In reply to :Gijs Kruitbosch from comment #15) > (In reply to Marco Castelluccio [:marco] from comment #14) > > I can't reproduce the problem of the screenshot, the tabs aren't opened > > halfway anymore. > > But I can still reproduce the button flashing. > > You mean it's on briefly as the new tab goes into view, and then is disabled > again? That happens on Nightly too... When you close a tab, the arrow button goes from enabled to disabled and from disabled to enabled several times. On Nightly the button is never enabled. (I'm talking about closing a tab, not opening)
(In reply to Marco Castelluccio [:marco] from comment #16) > (In reply to :Gijs Kruitbosch from comment #15) > > (In reply to Marco Castelluccio [:marco] from comment #14) > > > I can't reproduce the problem of the screenshot, the tabs aren't opened > > > halfway anymore. > > > But I can still reproduce the button flashing. > > > > You mean it's on briefly as the new tab goes into view, and then is disabled > > again? That happens on Nightly too... > > When you close a tab, the arrow button goes from enabled to disabled and > from disabled to enabled several times. > On Nightly the button is never enabled. > > (I'm talking about closing a tab, not opening) Comment 9 was about opening a tab... In any case, I can't reproduce this on Windows. Are you using Firefox in restored, maximized or fullscreen? What theme are you using? What version of Windows? And you're on either today's or yesterday's nightly?
Attached video test.avi (deleted) —
(In reply to :Gijs Kruitbosch from comment #17) > Comment 9 was about opening a tab... In any case, I can't reproduce this on > Windows. Are you using Firefox in restored, maximized or fullscreen? What > theme are you using? What version of Windows? And you're on either today's > or yesterday's nightly? Yes, the problem in comment 9 is fixed now. I'm using Firefox in maximized mode, default theme, Windows 7, today's nightly.
Attachment #812339 - Attachment is obsolete: true
Attachment #812340 - Attachment is obsolete: true
I can't reproduce on my second machine. Maybe it's the different resolution? The first machine has a high-resolution display.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(In reply to Marco Castelluccio [:marco] from comment #19) > I can't reproduce on my second machine. Maybe it's the different resolution? > The first machine has a high-resolution display. Can you reproduce on the first machine with a clean profile?
(In reply to :Gijs Kruitbosch from comment #20) > (In reply to Marco Castelluccio [:marco] from comment #19) > > I can't reproduce on my second machine. Maybe it's the different resolution? > > The first machine has a high-resolution display. > > Can you reproduce on the first machine with a clean profile? Ah, nevermind. Updated STR: 1. Set font size in the "Display" part of the Win7 preferences to 125% 2. Log off and back on 3. Open enough tabs to overflow 4. Close the last tab
Summary: [Australis] Closing tab causes the overflow arrow button to flash → [Australis][Win7][hidpi] In >100%dpi, closing tab when tabbar is overflowing causes the end arrow to flicker
Whiteboard: [Australis:P3] → [Australis:P3][str in comment 21]
Keywords: helpwanted
Given that the difference between the two arrow states is kind of subtle, I think that will make the flickering less noticeable/janky than it otherwise might be (although I didn't actually test this on Windows!) The arrows end up in the right state at the end, right?
Whiteboard: [Australis:P3][str in comment 21] → [Australis:P4][str in comment 21]
Whiteboard: [Australis:P4][str in comment 21] → [Australis:P4-][str in comment 21]
Status: REOPENED → RESOLVED
Closed: 11 years ago → 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: