Closed Bug 905065 Opened 11 years ago Closed 9 years ago

[FlatFish][BuildingBlocks] Shared style modification for Tablet

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: gasolin, Unassigned)

References

Details

(Whiteboard: [flatfish][TCP=feature-p1])

Attachments

(3 files, 1 obsolete file)

[Flatfish] AppFramework1021.pdf
(deleted), application/pdf
Details
PR to master
(deleted), text/html
Details
System_20131031.pdf
(deleted), application/pdf
Details
To support large device we have some style modifications in shared/style. Since building block is also in refactor mode, we'd like to collect all shared style modifications for reference and help building block team collect large device related changes.
Blocks: flatfish
It's a must for flatfish. Marked as koi+ according to triage result.
blocking-b2g: --- → koi+
Whiteboard: [Flatfish only]
--- Since the basic layout works and 1.2 is target for minimum tablet support
blocking-b2g: koi+ → ---
Attached file [Flatfish] AppFramework1021.pdf (deleted) —
Hi all, spec uploaded.
Blocks: 932081
Summary: [FlatFish][BuildingBlocks] Shared style modification for Large Device → [FlatFish][BuildingBlocks] Shared style modification for Tablet
We'd start from header styles. Due to time bound, we'd try to commit style changes to each app, then try to distill them to building block. We agreed to put building block related change in the bottom of each @media-query section
Attached file PR to master (deleted) —
This patch has modified the header of tablet.
Attachment #826634 - Flags: review?
Assignee: nobody → gduan
Comment on attachment 826634 [details] PR to master Hi Arnau, could you kindly help me to review it? Thanks.
Attachment #826634 - Flags: review? → review?(arnau)
Attached file System_20131025.pdf (obsolete) (deleted) —
Attach header and toolbar spec. The left button on header should be 5px-width as discussed with our visual team. Hi Helen, could you confirm on that? Thanks.
Hi Arnau, I just updated what you suggested, please kindly check it again. Thanks.
Flags: needinfo?(arnau)
Flags: needinfo?(hhuang)
Correct myself, 5rem-width (In reply to George Duan [:gduan] from comment #7) > Created attachment 830175 [details] > System_20131025.pdf > > Attach header and toolbar spec. > The left button on header should be 5px-width as discussed with our visual > team. > > Hi Helen, > could you confirm on that? Thanks.
Attached file System_20131031.pdf (deleted) —
Visual spec has been updated. The left button on header is 5rem-width.
Attachment #830175 - Attachment is obsolete: true
Flags: needinfo?(hhuang)
blocking-b2g: --- → 1.3+
Whiteboard: [Flatfish only] → [Flatfish only][developer+]
blocking-b2g: 1.3+ → ---
Whiteboard: [Flatfish only][developer+] → [Flatfish only][developer+][TCP]
Blocks: flatfish-ux
No longer blocks: flatfish
I'm cancelling all old Flatfish ni and reviews till we have final specs. Feel free to ping me again.
Flags: needinfo?(rnowmrch)
Comment on attachment 826634 [details] PR to master I'm cancelling all old Flatfish ni and reviews till we have final specs. Feel free to ping me again.
Attachment #826634 - Flags: review?(rnowmrch)
Whiteboard: [Flatfish only][developer+][TCP] → [flatfish][TCP]
Whiteboard: [flatfish][TCP] → [flatfish][TCP=feature-p1]
Close this bug based on comment 11 .
Assignee: gduan → nobody
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: