Closed Bug 905072 Opened 11 years ago Closed 11 years ago

non-public application returned by the export API

Categories

(Marketplace Graveyard :: API, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
2013-10-28

People

(Reporter: nati, Assigned: ashort)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36 Steps to reproduce: Download the latest prod app dump from: https://marketplace.cdn.mozilla.net/dumped-apps/tarballs/2013-08-13.tgz Actual results: found /apps/420/420476.json ('youzeek-free-music-streaming') in the dump, which is a non-public application: https://marketplace.firefox.com/api/v1/apps/app/420476/?format=JSON Expected results: 1. This app should be public OR 2. This app shouldn't been exported OR 3. The Export documentation should be amended
Assignee: nobody → ashort
Priority: -- → P3
This is important to fix as it allows people to access things that they should not be allowed to.
Priority: P3 → P1
Blocks: 875170
We were not deleting old exported apps when constructing a new tarball. Thus, apps that were once public remain in later exports even if made non-public later. https://github.com/mozilla/zamboni/commit/433c5f2d
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-10-28
Nati, can you verify this in the latest dump?
Flags: needinfo?(nati)
Please wait for tomorrow's dump to test - the one for 2013-10-29 was generated before the push containing the fix.
(In reply to Ran Ben Aharon (Everything.me) from comment #5) > Nati, can you verify this in the latest dump? The latest dumps seem OK, no broken or private apps. Thanks!
Flags: needinfo?(nati)
You need to log in before you can comment on or make changes to this bug.