Closed
Bug 90526
Opened 23 years ago
Closed 23 years ago
Retire gtkEmbed test app in favor of TestGtkEmbed app
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mcafee, Assigned: mcafee)
References
Details
Attachments
(2 files)
(deleted),
patch
|
jud
:
review+
blizzard
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
adamlock
:
review+
blizzard
:
superreview+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•23 years ago
|
||
Retire gtkEmbed test app in favor of TestGtkEmbed app.
Some issues here re: running memory tests, we should
try to migrate everything to TestGtkEmbed, that's
working better and is a better code example.
Comment 2•23 years ago
|
||
Where/how do we get TestGtkEmbed? Any tricks--other than those already employed
with gtkEmbed--to building it for leaks and reflow testing?
Comment 3•23 years ago
|
||
Do we need both a testGtkEmbed and a gtkEmbed. Since I'm not up on what the
differences are I don't the answer. Can we just turn testGtkEmbed into gtkEmbed
and make it transparent to our automated test scripts?
Comment 4•23 years ago
|
||
I'm not sure what's in gtkEmbed that we need to move. There are some things.
Someone should make a list here.
Updated•23 years ago
|
QA Contact: mdunn → depstein
Assignee | ||
Comment 5•23 years ago
|
||
TestGtkEmbed is now packaged in the tar file by default,
is it ok from a testing standpoint to take gtkEmbed out
of the tar file? I suggest we remove this in stages:
1) take gtkEmbed out of the tar file
2) stop building gtkEmbed by default
3) remove the code
Assignee | ||
Comment 6•23 years ago
|
||
Assignee | ||
Comment 7•23 years ago
|
||
request for r, sr for last patch to stop building gtkEmbed.
Updated•23 years ago
|
Attachment #53807 -
Flags: review+
Comment 8•23 years ago
|
||
sr=alecf contingent upon an r/sr= from blizzard, since he owns this stuff.
Should we be removing these files from the tree? i.e. is this still a good
example, or does it contain hacks that we avoid showing to future embeddors?
Comment 9•23 years ago
|
||
Please let it die. I'm sick of getting email about problems with it. r/sr=blizzard
Updated•23 years ago
|
Attachment #53807 -
Flags: superreview+
Assignee | ||
Comment 10•23 years ago
|
||
gtkEmbed is now not-built, next step is to remove the code and references to
gtkEmbed.
Assignee | ||
Comment 11•23 years ago
|
||
Assignee | ||
Comment 12•23 years ago
|
||
latest patch, plus cvs removing embedding/tests/gtkEmbed should finish this off.
Looking for r/sr.
Comment 13•23 years ago
|
||
Comment on attachment 54019 [details] [diff] [review]
patch to remove last references to gtkEmbed
r=adamlock
Attachment #54019 -
Flags: review+
Comment 14•23 years ago
|
||
Comment on attachment 54019 [details] [diff] [review]
patch to remove last references to gtkEmbed
sr=blizzard
Attachment #54019 -
Flags: superreview+
Assignee | ||
Comment 15•23 years ago
|
||
fixed, gtkEmbed is history now.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 16•23 years ago
|
||
Verified in 10/19 mozilla nightly build. References to gtkEmbed were removed in
makefiles:
* removed from makefile.in
* removed from allmakefiles.sh
* removed from basebrowser-unix. TestGtkEmbed was added.
* moz/embedding/tests/gtkEmbed removed from mk_sdk_hdr_lst.pl.
"$moz/embedding/browser/gtk/tests" was added.
Also, gtkEmbed is not on the tree.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•