+++ This bug was initially created as a clone of Bug #898919 +++ Bug 898919 fix only b2g v1.1. Since gfx layer refactoring, layer's code is very different ,then handle the problem as a different bug. Master also need to think about support of JB gonk.

(In reply to Sotaro Ikeda [:sotaro] from comment #0) > +++ This bug was initially created as a clone of Bug #898919 +++ > > Bug 898919 fix only b2g v1.1. Since gfx layer refactoring, layer's code is > very different ,then handle the problem as a different bug. Master also need > to think about support of JB gonk. This should be koi then, not leo, right?

(In reply to Jason Smith [:jsmith] from comment #1) > > This should be koi then, not leo, right? Yes, to be koi.

In ICS, compositionComplete() is called like the following. LayerManagerComposite::Render() ->CompositorOGL::EndFrame() ->GLContextEGL::SwapBuffers() ->GonkDisplayICS::SwapBuffers() ->FramebufferNativeWindow::compositionComplete()

Comment on attachment 791417 [details] [diff] [review] patch - Call compositionComplete() Can I have a feedback to the patch?

Comment on attachment 791417 [details] [diff] [review] patch - Call compositionComplete() Review of attachment 791417 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/gonk/libdisplay/GonkDisplayJB.cpp @@ +166,5 @@ > StopBootAnimation(); > mBootAnimBuffer = nullptr; > > + // Should be called when composition rendering is complete for a frame. > + // Only HWC v1.0 needs this call. I think this should say what happens for HWC > 1.0. Is it harmless to call it or does it have to be removed?

(In reply to Benoit Girard (:BenWa) from comment #6) > Comment on attachment 791417 [details] [diff] [review] > patch - Call compositionComplete() > > Review of attachment 791417 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: widget/gonk/libdisplay/GonkDisplayJB.cpp > @@ +166,5 @@ > > StopBootAnimation(); > > mBootAnimBuffer = nullptr; > > > > + // Should be called when composition rendering is complete for a frame. > > + // Only HWC v1.0 needs this call. > > I think this should say what happens for HWC > 1.0. Is it harmless to call > it or does it have to be removed? I will update in next patch. (HWC > 1.0) case is already handled in current code. mFBDevice is present only when (HWC == 1.0). http://mxr.mozilla.org/mozilla-central/source/widget/gonk/libdisplay/GonkDisplayJB.cpp#66

In (HWC > 1.0) case, do not compositionComplete().

Apply the comment.

Comment on attachment 791449 [details] [diff] [review] patch v2 - Call compositionComplete() mwu, can you review the patch?

Add header to the patch. Carry "mwu: review+".