Make sure we've updated entity names accordingly for all new and updated strings.

Differences between mozilla-central and projects/fig on the two paths containing strings for Fennec. Path: /mobile/android/locales/en-US/chrome Files modified: aboutAddons.dtd Path: /mobile/android/base/locales/en-US Files modified: android_strings.dtd I'll have a deeper look, testing the nightly from fig, but everything seems good so far.

As far as I can tell, after having checked the running app, all strings have been renamed or removed, I don't see any strings modified while maintaining the old ID. +<!ENTITY bookmarks_title "Bookmarks"> +<!ENTITY history_title "History"> These are two of the three top titles, the other one is the existing "Reading list", which used to be a folder's name in bookmarks. Not sure if it's worth changing the id (maybe readinglist_title?). <!ENTITY reading_list "Reading List"> How are these strings transformed to upper case? Can't find the following strings in the interface (version 2013-08-13) +<!ENTITY all_pages_title "Top Sites"> +<!ENTITY contextmenu_remove "Remove"> (I get only Edit on context menu) +<!ENTITY bookmark_add "Add a bookmark"> +<!ENTITY home_last_tabs_title "Tabs from last time"> +<!ENTITY home_last_tabs_open "Open all tabs from last time"> The first one I can't even find in the code except for a couple of declarations.

(In reply to Francesco Lodolo [:flod] from comment #2) > As far as I can tell, after having checked the running app, all strings have > been renamed or removed, I don't see any strings modified while maintaining > the old ID. > > +<!ENTITY bookmarks_title "Bookmarks"> > +<!ENTITY history_title "History"> > > These are two of the three top titles, the other one is the existing > "Reading list", which used to be a folder's name in bookmarks. Not sure if > it's worth changing the id (maybe readinglist_title?). > > <!ENTITY reading_list "Reading List"> This would cause unnecessary work for the translators, no? > How are these strings transformed to upper case? This is done by the platform (usually done through Android's TransformationMethod): http://developer.android.com/reference/android/text/method/TransformationMethod.html > Can't find the following strings in the interface (version 2013-08-13) > > +<!ENTITY all_pages_title "Top Sites"> > +<!ENTITY contextmenu_remove "Remove"> (I get only Edit on context menu) > +<!ENTITY bookmark_add "Add a bookmark"> > +<!ENTITY home_last_tabs_title "Tabs from last time"> > +<!ENTITY home_last_tabs_open "Open all tabs from last time"> > > The first one I can't even find in the code except for a couple of > declarations. Those might be leftovers but I have to double check.

(In reply to Lucas Rocha (:lucasr) from comment #3) > This would cause unnecessary work for the translators, no? Yes, but the same thing happens when you change the id for other strings (e.g. when you change from awesomebar_bookmarks_title to bookmarks_title, that's a new string for tools). I personally prefer one more string (20 vs 19, if I didn't count them wrong) to make localizers aware of the changed position/usage (and probably of the different space available).

(In reply to Francesco Lodolo [:flod] from comment #1) > Path: /mobile/android/locales/en-US/chrome > Files modified: aboutAddons.dtd FYI, this looks like a string that was just added on m-c and needs to be merged into fig, so that isn't actually related to the work we're doing.

(In reply to Francesco Lodolo [:flod] from comment #2) > +<!ENTITY all_pages_title "Top Sites"> Yes, this is unused. I'll remove it. > +<!ENTITY contextmenu_remove "Remove"> (I get only Edit on context menu) This is used for the home_remove context menu item, which should be shown on bookmarks or history items in the list views. (see bug 897250) > +<!ENTITY bookmark_add "Add a bookmark"> This is shown below empty top bookmark thumbnails, instead of a page title. > +<!ENTITY home_last_tabs_title "Tabs from last time"> This is used to set a title for the "Tabs from last time" page in the History tab. You may only see it if you do have tabs from last time. > +<!ENTITY home_last_tabs_open "Open all tabs from last time"> This is shown for a button on that page. You also won't see it unless you have tabs from last time listed there.

Here's a patch to remove the unused string and update the reading list title string.

Comment on attachment 791282 [details] [diff] [review] patch Review of attachment 791282 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Margaret, patch looks good to me. With your help I was able to find "Remove" and "Add a bookmark", not the "tabs from the last time" (I guess I'll have to understand how to get those tabs)

Comment on attachment 791282 [details] [diff] [review] patch Review of attachment 791282 [details] [diff] [review]: ----------------------------------------------------------------- Nice.