Closed
Bug 905472
Opened 11 years ago
Closed 11 years ago
Intermittent TEST-UNEXPECTED-FAIL | tests/test-tabs.test window focus changes active tab | the activated tab url is correct ([DATAURIs STRIPPED])
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(firefox24 unaffected, firefox25 unaffected, firefox26 fixed)
RESOLVED
FIXED
mozilla26
Tracking | Status | |
---|---|---|
firefox24 | --- | unaffected |
firefox25 | --- | unaffected |
firefox26 | --- | fixed |
People
(Reporter: KWierso, Assigned: evold)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
TEST-UNEXPECTED-FAIL | tests/test-tabs.test window focus changes active tab | the activated tab url is correct ("data:text/html;charset=utf-8,test%20window%20focus%20changes%20active%20tab</br><h1>Window%20#2" != "data:text/html;charset=utf-8,test%20window%20focus%20changes%20active%20tab%3C%2Fbr%3E%3Ch1%3EWindow%20%231")
https://tbpl.mozilla.org/php/getParsedLog.php?id=26565339&tree=Mozilla-Inbound#error0
TEST-UNEXPECTED-FAIL | tests/test-tabs.test window focus changes active tab | the activated tab url is correct ("data:text/html;charset=utf-8,test%20window%20focus%20changes%20active%20tab</br><h1>Window%20#2" != "data:text/html;charset=utf-8,test%20window%20focus%20changes%20active%20tab%3C%2Fbr%3E%3Ch1%3EWindow%20%231")
TEST-INFO | Traceback (most recent call last):
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/windows/observer.js", line 36, in handleEvent
this._emit(event.type, event.target, event);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
return this._emitOnObject.apply(this, args);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
listener.apply(targetObj, params);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/tabs/observer.js", line 92, in onWindowActivate
observer._emit("select", getActiveTab(chromeWindow));
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
return this._emitOnObject.apply(this, args);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
listener.apply(targetObj, params);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/tabs/observer.js", line 61, in onTabSelect
if (tab) observer._emit('activate', selectedTab = tab);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
return this._emitOnObject.apply(this, args);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
listener.apply(targetObj, params);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/windows/tabs-firefox.js", line 120, in _onTabEvent
this._emitEvent(type, wrappedTab);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/windows/tabs-firefox.js", line 128, in _emitEvent
tabs._emit.apply(tabs, args);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
return this._emitOnObject.apply(this, args);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
listener.apply(targetObj, params);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path.tests/tabs/test-firefox-tabs.js", line 849, in onActivate
test.assertEqual(tab.url, url1, 'the activated tab url is correct');
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 189, in assertEqual
this.fail(message);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 84, in fail
this.console.testMessage(false, false, this.test.name, message);
File "resource://extensions.modules.9bf9c7b4-8085-4d69-be55-f3624a75fdd4-at-jetpack.commonjs.path/sdk/test/harness.js", line 525, in testMessage
this.trace();
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → evold
Assignee | ||
Comment 4•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #790626 -
Flags: review?(dtownsend+bugmail)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 7•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/c075bc92fea4c880f688052c1385844a7c416760
Bug 905472 - Intermittent TEST-UNEXPECTED-FAIL | tests/test-tabs.test window focus changes active tab | the activated tab url is correct
https://github.com/mozilla/addon-sdk/commit/e92d1b484cb7fa41a2b7d39e07f121ca9ec1ec48
Merge pull request #1173 from erikvold/905472
Bug 905472 - Intermittent TEST-UNEXPECTED-FAIL | tests/test-tabs.test window focus changes active tab | the activated tab url is correct. r=Mossop
Updated•11 years ago
|
Attachment #790626 -
Flags: review?(dtownsend+bugmail) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Updated•11 years ago
|
Priority: -- → P1
Comment 9•11 years ago
|
||
It looks like we might have got this!
https://hg.mozilla.org/integration/fx-team/rev/59f75442d028
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-firefox24:
--- → unaffected
status-firefox25:
--- → unaffected
status-firefox26:
--- → fixed
Target Milestone: --- → mozilla26
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 18•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•