Closed
Bug 905606
Opened 11 years ago
Closed 11 years ago
Gaia for bug 892212 Support for BT inline pairing User
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jcheng, Assigned: iliu)
References
Details
(Whiteboard: [u=devices c=BT p=0] )
Attachments
(1 file)
(deleted),
text/html
|
jj.evelyn
:
review+
cawang
:
ui-review+
jj.evelyn
:
feedback+
|
Details |
This tracks gaia work for BT inline pairing
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → iliu
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Reporter | ||
Updated•11 years ago
|
Whiteboard: [u= c= p=0]
Reporter | ||
Updated•11 years ago
|
Whiteboard: [u= c= p=0] → [u=devices c=BT p=0]
Assignee | ||
Comment 1•11 years ago
|
||
Hi Evelyn and Arthur,
Could you please give some feedback for the WIP? The mainly functionality is working on build id 20130906040204. My device is inari. I'm keeping to finish the device status change, error case in detail after a user clicked a device. There is some icon and strings needing to be updated. Thanks.
Attachment #802236 -
Flags: feedback?(ehung)
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 802236 [details]
Pointer to Github pull request 12069.html
The patch is updated with correct UI flow. I think Evelyn and Arthur are able to review the pr, if one of you is available. Thanks.
Attachment #802236 -
Flags: ui-review?(cawang)
Attachment #802236 -
Flags: review?(ehung)
Attachment #802236 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 3•11 years ago
|
||
Since there are some refinement of Bluetooth sendFile API via Bug 906305, the issue is blocked via Bug 910140. Once Bug 910140 is fixed, Bluetooth file transfer should be work.
Depends on: 910140
Comment 4•11 years ago
|
||
Comment on attachment 802236 [details]
Pointer to Github pull request 12069.html
r=me, I think the whole function works as I understand but the code needs to be cleaned up. I see many irreverent function and CSS style copied from Settings app, I've pointed some of them out, but please do carefully check again. I'd like to review again after clean up. Thanks.
Attachment #802236 -
Flags: review?(ehung)
Attachment #802236 -
Flags: review-
Attachment #802236 -
Flags: feedback?(ehung)
Attachment #802236 -
Flags: feedback+
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 802236 [details]
Pointer to Github pull request 12069.html
Hi Evelyn,
I have updated the patch according to your reviewed suggestion. Please help to review it again. Thanks.
* Remove useless functions
* Remove useless CSS style sheet, image, icon..
* Replace older customization bb with shared/style/confirm.css
* Remove utils.js
Attachment #802236 -
Flags: review- → review?(ehung)
Comment 6•11 years ago
|
||
Comment on attachment 802236 [details]
Pointer to Github pull request 12069.html
Just checked the flow with Ian. Basically the flow looks ok to me, but we faced system crash several times. Ian will revise it and hv UX review again later.
Thanks!
Updated•11 years ago
|
Attachment #802236 -
Flags: ui-review?(cawang) → ui-review+
Assignee | ||
Comment 7•11 years ago
|
||
Evelyn and Carrie,
Thanks for your reviewing effort.
Assignee | ||
Comment 8•11 years ago
|
||
Arthur and Eric,
I update the modification and status of the patch:
* Remove custom value selector(older paired devices list)
* Add device list component which is almost same with settings app::bluetooth(without toggle bluetooth, visible, and rename device's name)
* There is a workaround for waiting bluetooth protocol channel ready.
- https://github.com/mozilla-b2g/gaia/pull/12069/files#L0R275
- We will remove the workaround once "Bug 915602 - [Bluetooth] Call sendFile api will crash the system while device is just paired." is fixed.
* There is no 'bluetooth-pairing-request' system message callback in the first time, if we use bluetooth inline pairing.
- Track: Bug 915611 - [Bluetooth] Cannot receive 'bluetooth-pairing-request' system message callback in the first time, if we use bluetooth inline pairing.
* The description strings "Check the progress in Notification center" is truncated on notification centre.
- UX will discuss a better solution for notification truncated issue.
Thanks.
Comment 9•11 years ago
|
||
Comment on attachment 802236 [details]
Pointer to Github pull request 12069.html
r=me with comment addressed. The function works well but most of the code are copied from Settings app. I hope you can open a follow-up bug for extracting common logic to a shared utility object. Thanks for your big patch and timely support. :)
Clear Arthur's review request as well.
Attachment #802236 -
Flags: review?(ehung)
Attachment #802236 -
Flags: review?(arthur.chen)
Attachment #802236 -
Flags: review+
Comment 10•11 years ago
|
||
Comments addressed.
master:8d5ae6f7d1b874e214ade29f9fd78b7cc49d7e47
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•11 years ago
|
||
Hi Evelyn and Arthur,
Thanks for your reviewing effort with so much patient. In section of duplicating code, let's track it via Bug 916642 - [Bluetooth File Transfer][Settings] Extracting common logic to a shared utility object from the two apps.
You need to log in
before you can comment on or make changes to this bug.
Description
•