Closed
Bug 905621
Opened 11 years ago
Closed 11 years ago
Stylize the bad url error page
Categories
(Firefox for Metro Graveyard :: Theme, defect, P2)
Tracking
(firefox28 fixed, firefox29 fixed)
RESOLVED
FIXED
Firefox 29
People
(Reporter: jimm, Assigned: mmaslaney)
References
Details
(Keywords: uiwanted, Whiteboard: [beta28] [ux] p=0 [qa-])
Attachments
(3 files, 1 obsolete file)
This page is fairly common, and totally clashes with the metro theme. Shouldn't be too hard to fix it up if we have a new comp.
Updated•11 years ago
|
Blocks: metrov1backlog
Summary: Stylize the bad url error page → Defect - Stylize the bad url error page
Whiteboard: [preview-triage] → [preview-triage] feature=defect c=tbd u=tbd p=0
Updated•11 years ago
|
Blocks: MetroPreviewRelease
Summary: Defect - Stylize the bad url error page → [MP] Defect - Stylize the bad url error page
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=0
Reporter | ||
Updated•11 years ago
|
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview][l10n] feature=defect c=tbd u=tbd p=0
Updated•11 years ago
|
No longer blocks: MetroPreviewRelease
Summary: [MP] Defect - Stylize the bad url error page → Defect - Stylize the bad url error page
Whiteboard: [preview][l10n] feature=defect c=tbd u=tbd p=0 → [l10n] feature=defect c=tbd u=tbd p=0
Reporter | ||
Comment 1•11 years ago
|
||
Yuan, do you have time for this? If not, we can kick it to another release.
Flags: needinfo?(ywang)
Comment 2•11 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #1)
> Yuan, do you have time for this? If not, we can kick it to another release.
I think that should be fairly easy.
Flags: needinfo?(ywang)
Updated•11 years ago
|
Whiteboard: [l10n] feature=defect c=tbd u=tbd p=0 → [block28] [l10n] feature=defect c=tbd u=tbd p=0
Comment 3•11 years ago
|
||
Apply the same style as other in-content pages, such as crash reporting.
Will ping Michael about visual details early next week.
Updated•11 years ago
|
Whiteboard: [block28] [l10n] feature=defect c=tbd u=tbd p=0 → [release28] feature=defect c=tbd u=tbd p=0
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mmaslaney
Updated•11 years ago
|
Blocks: Backlog-MetroDesign
Updated•11 years ago
|
Whiteboard: [release28] feature=defect c=tbd u=tbd p=0 → [beta28] feature=defect c=tbd u=tbd p=0
Updated•11 years ago
|
Summary: Defect - Stylize the bad url error page → Stylize the bad url error page
Whiteboard: [beta28] feature=defect c=tbd u=tbd p=0 → [defect] [beta28] p=0
Updated•11 years ago
|
Whiteboard: [defect] [beta28] p=0 → [beta28] [defect] p=0
Updated•11 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Assignee | ||
Comment 4•11 years ago
|
||
The following attachment contains the following:
• InContent error page
• InContent design template for future use
• Specs for margins, button margins, button css and type css
• Iconography assets
Comment 5•11 years ago
|
||
Implementation to be tracked via Bug 957806.
Updated•11 years ago
|
Whiteboard: [beta28] [defect] p=0 → [beta28] [ux] p=0
Updated•11 years ago
|
Target Milestone: --- → Firefox 29
Comment 7•11 years ago
|
||
Marking as fixed for Fx28 too to get this off our uplift radar (since there's no code to uplift in this design-only bug).
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Comment 8•11 years ago
|
||
Hey Matt, based on your update in Comment 7, can I mark the Bug 957806 (the implementation of these assets) as invalid?
Flags: needinfo?(mbrubeck)
Comment 9•11 years ago
|
||
(In reply to Marco Mucci [:MarcoM] from comment #8)
> Hey Matt, based on your update in Comment 7, can I mark the Bug 957806 (the
> implementation of these assets) as invalid?
No, that bug is still valid (and unlike this one, it *will* contain the actual code changes and will need uplift to Aurora).
Flags: needinfo?(mbrubeck)
Comment 10•11 years ago
|
||
(In reply to mmaslaney from comment #4)
> • Specs for margins, button margins, button css and type css
The button styles here are slightly different from the button styles we are currently using in the browser chrome (added in bug 838211). Is this intentional, or should we choose one style for both chrome and in-content UI? It's fine if they're meant to differ; I just wanted to double check...
Flags: needinfo?(mmaslaney)
Assignee | ||
Comment 11•11 years ago
|
||
My initial intent was to have them look consistent with the platform, but after some thought, I believe we should keep them consistent across the board (within Firefox) as to promote a stable experience.
Let's keep the proposed margins/size and utilize the existing button styling.
Flags: needinfo?(mmaslaney)
Comment 12•11 years ago
|
||
Kamil, please verify this is fixed in the latest Firefox Nightly and Aurora builds.
Flags: needinfo?(kamiljoz)
Comment 13•11 years ago
|
||
The implementation of these designs is in 957806 which has not yet landed, there's nothing to QA on this bug.
Flags: needinfo?(kamiljoz)
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•