Closed
Bug 906025
Opened 11 years ago
Closed 11 years ago
[responsive mode] vertical resizer moves incorrectly after rotate
Categories
(DevTools :: Responsive Design Mode, defect)
Tracking
(firefox25 verified, firefox26 verified)
VERIFIED
FIXED
Firefox 26
People
(Reporter: andre42m, Assigned: andre42m)
Details
Attachments
(1 file)
(deleted),
patch
|
paul
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130730113002
Steps to reproduce:
Use the vertical resizer and then rotate.
Actual results:
The vertical resizer goes to a incorrect position.
Expected results:
The vertical resizer should stay centered.
Assignee | ||
Updated•11 years ago
|
Component: Untriaged → Developer Tools: Responsive Mode
Comment 1•11 years ago
|
||
I can't reproduce. Can you reproduce in Firefox Aurora and Firefox Nightly?
Comment 2•11 years ago
|
||
Ok - I see what the issue is. A rotate right after a resize does move the handle correctly.
Comment 3•11 years ago
|
||
Comment on attachment 791259 [details] [diff] [review]
patch-fix-rotate
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 778174
User impact if declined: "rotate" button doesn't work properly
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #791259 -
Attachment is patch: true
Attachment #791259 -
Flags: review+
Attachment #791259 -
Flags: approval-mozilla-beta?
Comment 5•11 years ago
|
||
(In reply to Paul Rouget [:paul] from comment #3)
> Comment on attachment 791259 [details] [diff] [review]
> patch-fix-rotate
>
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): bug 778174
> User impact if declined: "rotate" button doesn't work properly
> Testing completed (on m-c, etc.): locally
> Risk to taking this patch (and alternatives if risky): low
> String or IDL/UUID changes made by this patch: none
Looks like Fx25 is affected here given 778174 landed in 25.Not sure why this would be needed on beta, hence switching the approval nom to aurora.Feel free to renom if anything was understood wrong.
Comment 6•11 years ago
|
||
Comment on attachment 791259 [details] [diff] [review]
patch-fix-rotate
[Triage Comment]
Approving the low risk patch on aurora as this is a fallout from Bug 778174
Attachment #791259 -
Flags: approval-mozilla-beta? → approval-mozilla-aurora+
Comment 7•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Updated•11 years ago
|
Assignee: nobody → andreldm1989
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Comment 9•11 years ago
|
||
status-firefox25:
--- → fixed
status-firefox26:
--- → fixed
Comment 10•11 years ago
|
||
I confirm the fix is verified on FF 25b2 using Windows 7 x64
Keywords: verifyme → addon-compat
Updated•11 years ago
|
Keywords: addon-compat
Comment 11•11 years ago
|
||
Verified Fixed on Latest Aurora too.
OS: Windows 7 x64
Build ID: 20131009004001
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•