Closed Bug 906300 Opened 11 years ago Closed 8 years ago

Password auto-fill/autocompletion now works on Persona only when choosing the e-mail address while the password field is visible (that is, the second time and if prevented from disappearing)

Categories

(Cloud Services :: Server: Identity, defect)

x86_64
All
defect
Not set
normal

Tracking

(firefox23 unaffected, firefox24-, firefox25-, firefox26-)

RESOLVED WONTFIX
Tracking Status
firefox23 --- unaffected
firefox24 - ---
firefox25 - ---
firefox26 - ---

People

(Reporter: Aleksej, Unassigned)

References

()

Details

(Keywords: regression, Whiteboard: [qa+])

Attachments

(1 file)

Steps to reproduce: 1. Go to https://login.persona.org 's login page. 2. Log in, save password. 3. Log out. 4. Go to https://login.persona.org 's login page. 5. Enter your login (it will be autocompleted, you can choose that). 6. Press Enter (in the login field). Actual results: The password field appears empty. Expected results: The password field appears with the password (as **********). Regression range: WFM: 2013-06-20-03-10-10-mozilla-central-firefox-24.0a1.en-US.linux-x86_64 bug: 2013-06-21-03-10-51-mozilla-central-firefox-24.0a1.en-US.linux-x86_64 https://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2013-06-20&enddate=2013-06-21+03%3A10
Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/6ee152636ad4 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130619 Firefox/24.0 ID:20130619155313 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/1213ea1ff91a Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130619 Firefox/24.0 ID:20130619163255 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6ee152636ad4&tochange=1213ea1ff91a Regressed by: Bug 839961
Blocks: 839961
OS: Linux → All
needinfo'ing :Dolkse here for next steps. Also :dolske, do we think this may affect other websites in general or is this a persona thing ?
Flags: needinfo?(dolske)
WFM. It would probably be useful to see what pwmgr thinks is going on. Please attach a log here from https://wiki.mozilla.org/Firefox:Password_Manager_Debugging
Flags: needinfo?(dolske)
I've found a way to get the password filled: 1. When the password field appears after you've entered the e-mail address, either: a) enter something in the password field, so that it doesn't disappear when you focus the e-mail address field; b) don't use mouse for steps 2 and 3. 2. Do something to cause the e-mail address auto-completion drop-down to appear. 3. Choose the e-mail address and press Enter.
Is this separate from bug 759452?
:Dolske, anything useful from comment #4 ? Also we would track this for release only if its a generic issue, so please let us know.
Flags: needinfo?(dolske)
Clearing the tracking flags, until someone can help with additional information requested.Given the current state(intermittently reproducible) this would not be a blocker issue if this is limited to persona.Feel free to renominate if needed if anything was assumed wrong.
Summary: Password auto-fill/autocompletion stopped working on Persona → Password auto-fill/autocompletion now works on Persona only when choosing the e-mail address while the password field is visible (that is, the second time and if prevented from disappearing)
So, here's what's happening. (Did my testing with a new profile, and new non-@mozilla.com Persona account to make sure our LDAP stuff wasn't involved.) 0) Go to persona.org, click signon. Get the usual popup window. 1) Surprisingly, there is already a password field in this window. Password manager in fact fills it in -- I see my password in the input's .value with DOM Inspector. We also will in the username, but presumably the persona.org code is clearing it out immediately. 2) When you (re)enter your username and click "Next", this is triggering a form submission (with your password!), hence the "Login Manager: Modifying login" -- we see a form submission with an existing login, and are updating the lastUsed timestamp. 3) Clicking "Next" doesn't actually load a new page (if I set a dummy attribute on the username field, it's still there afterwards). So it's just reusing the same form, and so password manager never processes it again. But there's no password there now, so the page has cleared it out. So there are 2 Persona bugs here: - Don't clear the initial username field. This forces users to needlessly type in a username. - Don't clear the initial password field. Bonus points for catching that there's already a password present and using it (although the user could clear/edit the initial username field, so you'd need to watch for odd stuff like that). Alternatively, after Next is clicked, you could add a new <form> (or not add the password field until then) to trigger password manager's filling. That particular trick will only work in Nightly, because it requires bug 355063. (See also https://blog.mozilla.org/dolske/2013/08/20/on-firefoxs-password-manager/ and https://blog.mozilla.org/dolske/2013/08/21/a-change-in-password-manager/) Moving to Core::Identity, for lack of a better component, because Persona is unfortunately using a different bug tracker on Github.
Component: Password Manager → Identity
Flags: needinfo?(dolske)
Product: Toolkit → Core
Component: Identity → Server: Identity
Product: Core → Mozilla Services
Version: 24 Branch → unspecified
Whiteboard: [qa+]
:Dolske - Thanks for the analysis, very helpful. To your comment #1, when we first started BrowserID, the username/password fields were dynamically added to the DOM. At that time, the Firefox password manager was unable to pre-fill username/passwords on dynamically inserted content if the content was added post-DOMContentLoaded (See https://github.com/mozilla/browserid/issues/314 and https://bugzilla.mozilla.org/show_bug.cgi?id=355063). We modified our logic to ensure the username/password fields were always in the DOM. I just did a quick audit of the Persona code and we are indeed clearing the username and password on startup. The email is cleared in error, the password is cleared because of https://github.com/mozilla/browserid/issues/1540. Obviously, the logic for both of these needs refined. A new issue is opened at https://github.com/mozilla/browserid/issues/4009.
Persona has been discontinued, closing as WONTFIX.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: