Now that we've converted everything we don't need to use nsISupports anymore.

Comment on attachment 792344 [details] [diff] [review] Patch Review of attachment 792344 [details] [diff] [review]: ----------------------------------------------------------------- \o/ ::: dom/indexedDB/IDBRequest.cpp @@ +120,5 @@ > +void > +IDBRequest::AssertSourceIsCorrect() const > +{ > + // At most one of mSourceAs* is allowed to be non-null. Check that by > + // summing the negation of each one and asserting the sum is at least 2. I'd probably assert !!x + !!y + !!z <= 1 @@ +122,5 @@ > +{ > + // At most one of mSourceAs* is allowed to be non-null. Check that by > + // summing the negation of each one and asserting the sum is at least 2. > + > + unsigned sources = !mSourceAsObjectStore + !mSourceAsIndex + !mSourceAsCursor; Unused variable warning in opt builds @@ +126,5 @@ > + unsigned sources = !mSourceAsObjectStore + !mSourceAsIndex + !mSourceAsCursor; > + MOZ_ASSERT(sources >= 2); > +} > + > +void Trailing ws

Comment on attachment 792344 [details] [diff] [review] Patch Review of attachment 792344 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/indexedDB/IDBRequest.cpp @@ +87,5 @@ > + nsRefPtr<IDBRequest> request = Create(aOwnerCache, aTransaction); > + > + request->mSourceAsObjectStore = aSourceAsObjectStore; > + > + return request.forget(); I'd inline these puppies in the header file @@ +117,5 @@ > + return request.forget(); > +} > + > +void > +IDBRequest::AssertSourceIsCorrect() const Make this whole function #ifdef DEBUG @@ +123,5 @@ > + // At most one of mSourceAs* is allowed to be non-null. Check that by > + // summing the negation of each one and asserting the sum is at least 2. > + > + unsigned sources = !mSourceAsObjectStore + !mSourceAsIndex + !mSourceAsCursor; > + MOZ_ASSERT(sources >= 2); And I agree with ms2ger about checking for <= 1 instead.