Chris Lord [:cwiiis] Reporter
	Description • 11 years ago

If you browse to a page, click/touch in the page, then open a new tab with ctrl+t, the location bar appears to be focused, but does not actually hold focus (it's highlighted orange, but no cursor and typing doesn't work)

	Jonathan Wilde [:jwilde]
	Comment 1 • 11 years ago

Currently, the thing that gets highlighted is a xul box around the input, it's possible for that to get out of sync with the input. We need to look at making sure the editing state gets set and unset at all of the right times.

Alternately, we could just get rid of editing state and use CSS4 parent selectors (but I forget whether we implement those right now...).

	Rodrigo Silveira [:rsilveira] [:rodms] Assignee
	Comment 2 • 11 years ago

We're setting the focus while the navbar was not visible.

	Marco Mucci [:MarcoM]
	Comment 3 • 11 years ago

Hi Rodrigo, can you provide a point estimate for this defect.

	Matt Brubeck (:mbrubeck)
	Comment 5 • 11 years ago

Comment on attachment 796070 [details] [diff] [review]
Patch v2

Could you add a test for this too (maybe in browser_contextui.js)?

	Rodrigo Silveira [:rsilveira] [:rodms] Assignee
	Comment 6 • 11 years ago

Verified that it failed without the fix.

	Rodrigo Silveira [:rsilveira] [:rodms] Assignee
	Comment 7 • 11 years ago

Thanks!

https://hg.mozilla.org/integration/fx-team/rev/77e25cd0d80e
https://hg.mozilla.org/integration/fx-team/rev/17e8229405fe

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/77e25cd0d80e
https://hg.mozilla.org/mozilla-central/rev/17e8229405fe

	Manuela Muntean [Away]
	Comment 9 • 11 years ago

Verified as fixed, with the latest Nightly (build ID: 20130915030208), for iteration #14, on Win 8 64bit, by following the STR from comment 0.

I think this also needs some device verification.

	Kamil Jozwiak [:kjozwiak]
	Comment 10 • 11 years ago

Went through the following "Defect" for iteration #15 (touch device verification) without issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-15-03-03-19-mozilla-central/

- Went through the original defect described in comment #0 without any issues
- Ensured that the URL bar was selected with a cursor when using the CTRL + T method
- Ensured that the URL bar was selected with a cursor when using the "+" button in the "Tab App Bar"
- Ensured that the URL bar was selected with a cursor when using the junior style button
- Went through all of the above test cases in filled and full views without issues