Closed
Bug 907309
Opened 11 years ago
Closed 10 years ago
Avoid skipping frames in the image bridge
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
WONTFIX
| blocking-b2g | - |
People
(Reporter: jrmuizel, Unassigned)
Details
Attachments
(1 file)
|
(deleted),
patch
|
nical
:
feedback+
|
Details | Diff | Splinter Review |
Currently we only send the ImageContainer to the ImageBridge thread. This means that the active image can change before we get around to servicing it. This seems to be an unintentional change from the B2G 1.1 behaviour
|
Reporter | |
Comment 1•11 years ago
|
||
Here's a working version of this. This combined with the patch to hold a reference to the Image while the compositor has it, seems to let us get back up to 24fps h.264 video. However, we seem to be just barely there so I suspect that there may be other problems yet.
Note: it currently manually addrefs and release which should probably be fixed.
Attachment #792965 -
Flags: feedback?(nical.bugzilla)
|
||
Updated•11 years ago
|
Attachment #792965 -
Flags: feedback?(nical.bugzilla) → feedback+
|
||
Updated•11 years ago
|
blocking-b2g: --- → koi?
|
|
Reporter | |
Comment 3•11 years ago
|
||
I'm not sure. Sotaro what do you think?
Flags: needinfo?(jmuizelaar) → needinfo?(sotaro.ikeda.g)
|
|
||
Comment 4•11 years ago
|
||
We do not need this. ImageBridge is only used for video and camera preview rendering. In android case, only most recent video/camera frame is rendered. older frames are just dropped.
If we are going to get an use case of not to skip video frame, we should implement it by extending ImageContainer. It is consistent with the MediaStreamGraph.
Flags: needinfo?(sotaro.ikeda.g)
|
||
Updated•11 years ago
|
blocking-b2g: koi? → -
|
||
Comment 5•10 years ago
|
||
Based on comment 4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•