Closed Bug 9075 Opened 25 years ago Closed 25 years ago

script halts silently on document.doctype in XML

Categories

(Core :: DOM: Core & HTML, defect, P3)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: dbaron, Assigned: nisheeth_mozilla)

References

(
URL
)

Details

Script halts silently when it encounters document.doctype in XML. See the above test page. It halts while processing notNullWarn("document.doctype") . (Note that the only other problems in the test, with all doctype stuff removed, are the known nodeValue "" vs null problem and the case stuff that you can see already, which I guess I'll report...)
Assignee: vidur → nisheeth
I don't get a silent failure (Sept14-ish build), I now get: XML Error in file 'http://www.fas.harvard.edu/~dbaron/dom/test/one-core-xml/DocumentType_1', Line Number: 7, Col Number: 101, Description: error in processing external entity reference Source Line: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/strict.dtd"> from Doctype1 and XML Error in file 'http://www.fas.harvard.edu/~dbaron/dom/test/one-core-xml/DocumentType_2', Line Number: 10, Col Number: 46, Description: error in processing external entity reference Source Line: "http://www.w3.org/TR/xhtml1/DTD/strict.dtd"> from Doctype2. This seems like either a document error or a parser problem, so I'm handing it to nisheeth.
Depends on: 10456
You're seeing another bug that started after I filed this one. So I'm marking this bug as depending on bug 10456, since bug 11948 was marked a dup of it.
Fair enough. I'm moving this past beta; if you object violently, please make your case below. =)
Status: NEW → ASSIGNED
Accepting bug...
Should this be assigned back to vidur now? I'm not quite sure how doctype should be implemented with a non-validating parser. That should be brought up in the DOM WG. I guess entities and notations should either be null or empty.
Vidur's bug list is quite large so I don't want to send this to him without some more analysis. I'll bring this up with him offline and get the DOM perspective on this.
Depends on: 15118
This is probably happening because we don't construct the doctype DOM node in the XML content sink. I'm marking this bug dependent on bug 15118, the bug for creating current unused XML content objects.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I've changed nsXMLDocument::GetDocType to return NS_OK instead of NS_ERROR_NOT_IMPLEMENTED. Now, the script does not halt but you get back a null doctype. I'm closing this bug. Once I add code to create doctype nodes, I'll make them accesible via the DOM.
Mass update of qa contact
QA Contact: gerardok → janc
Component: DOM Level 1 → DOM HTML
QA contact Update
QA Contact: janc → desale
Updating QA contact to Shivakiran Tummala.
QA Contact: desale → stummala
verified on linux for build 2001070908... document.doctype---returning null and the script does not halt...
Status: RESOLVED → VERIFIED
Component: DOM: HTML → DOM: Core & HTML
QA Contact: stummala → general
You need to log in before you can comment on or make changes to this bug.