Closed Bug 907546 Opened 11 years ago Closed 6 years ago

Avoid DC readback on windows at all cost.

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: jrmuizel, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [Australis:P-])

When ever we hit this path in cairo we get a bunch of sadness. Unfortunately we can't just switch to image surfaces because we still need to draw text through GDI
Depends on: 907542, 907544, 907426
We measured the cost of the read back during Tart tab animation test on basic layers and fixing it seemed to improve the scores by about 30% (this was just eyeballing the numbers which I'm bad at)
Whiteboard: [Australis:P?][Australis:M?]
Marking P1 as fixing this will give us a major boost on TART performance which is currently holding us back from landing.
Whiteboard: [Australis:P?][Australis:M?] → [Australis:P1][Australis:M1]
Whiteboard: [Australis:P1][Australis:M1] → [Australis:P1][Australis:M?]
It's unclear how fixing this bug will help our benchmark performance and this is not a regression introduced by Australis, so we'll be untracking this bug from Australis.
No longer blocks: australis-tart
Whiteboard: [Australis:P1][Australis:M?]
To be clear, it's unclear how this will help us on Windows XP which is our only Windows platform that is regressing the benchmark.
Blocks: australis-tart
Because we hit this path on Windows XP. And it's currently slow.
Blocks: 922265
Whiteboard: [Australis:P-]
Is this bug still relevant?
Flags: needinfo?(jmuizelaar)
Nope.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(jmuizelaar)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.