Closed
Bug 907850
Opened 11 years ago
Closed 11 years ago
Add a little space around the reader icon in awesomescreen tip
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: ibarlow, Assigned: liuche)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
The reader icon in our tip is sitting a little too close to the text that surrounds it. Maybe add a single character space to the left and to the right of it, to make it feel less cramped?
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → liuche
Assignee | ||
Comment 1•11 years ago
|
||
Adding this in-code instead of in string resources so that if the "%I" gets dropped in localization, we don't get extra spaces.
Attachment #795544 -
Flags: review?(sriram)
Comment 2•11 years ago
|
||
Comment on attachment 795544 [details] [diff] [review]
Patch: Add spacing around icon.
How would this work with l10n?
Attachment #795544 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> Comment on attachment 795544 [details] [diff] [review]
> Patch: Add spacing around icon.
>
> How would this work with l10n?
There is a localization note in the android strings that asks localizers to move the "%I" substring to wherever the image should be located. If the %I is somehow dropped, we just won't add in the icon; if the icon is moved elsewhere, we add the spacing in Java so that localizers don't need to move the extra spaces as well.
I think I'll also add a clarification to the localization note to keep the spacing around the "%I" string.
Assignee | ||
Comment 4•11 years ago
|
||
Add clarification in localization note, carrying over r+.
Attachment #795544 -
Attachment is obsolete: true
Attachment #795558 -
Flags: review+
Assignee | ||
Comment 5•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
OS: Mac OS X → Android
Hardware: x86 → ARM
Target Milestone: --- → Firefox 26
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•