Closed
Bug 908006
Opened 11 years ago
Closed 11 years ago
about:addons content disappears when scrolling page with mouse wheel or trackpad
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
Tracking | Status | |
---|---|---|
firefox25 | --- | unaffected |
firefox26 | --- | affected |
People
(Reporter: cpeterson, Unassigned)
References
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
STR:
1. Load about:addons
2. Scroll the page with a mouse wheel or trackpad
RESULT:
The list of addons disappeared, but the rest of the page is still visible.
This bug also affects the "Edit Page" textarea of wiki.mozilla.org but Wikipedia:
https://wiki.mozilla.org/index.php?title=Firefox&action=edit
https://en.wikipedia.org/w/index.php?title=Firefox&action=edit
This bug look like another regression from OSX texture bug 900133.
This is a regression in Nightly build 2013-08-21. I bisected the TBPL builds from mozilla-inbound from the prior day and the regression range is includes bug 900133:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0f68b32be429&tochange=252dbb41d609
Comment 1•11 years ago
|
||
We get a cairo error on smaller strides and cairo refuses to draw our mask.
Attachment #794448 -
Flags: review?(nical.bugzilla)
Comment 2•11 years ago
|
||
This works around some weird Quartz bugs with A8 surfaces. Previously we just manually cleared these surfaces instead (see the #ifdef XP_MACOSX in ISurfaceAllocator.cpp), but I think this makes more sense.
Attachment #794450 -
Flags: review?(nical.bugzilla)
Comment 3•11 years ago
|
||
Comment on attachment 794448 [details] [diff] [review]
Align strides to at least 4
Review of attachment 794448 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/ImageDataSerializer.cpp
@@ +73,5 @@
> gfx::SurfaceFormat aFormat)
> {
> // Note that at the moment we pack the image data with the minimum possible
> // stride, we may decide to change that if we want aligned stride.
> + uint32_t bufsize = aSize.height * ComputeStride(aFormat, aSize.width);
please remove the comment above now that we have an aligned stride.
Attachment #794448 -
Flags: review?(nical.bugzilla) → review+
Updated•11 years ago
|
Attachment #794450 -
Flags: review?(nical.bugzilla) → review+
Comment 4•11 years ago
|
||
> please remove the comment above now that we have an aligned stride.
Actually never mind, it is Saturday for Matt so I fixed the comment and will land as soon as inbound reopens
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Backed out for Linux and OSX reftest failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/76a5ca209147
https://tbpl.mozilla.org/php/getParsedLog.php?id=26934249&tree=Mozilla-Inbound
Comment 7•11 years ago
|
||
Just relanding the first part, since the latter caused a bunch of fuzz failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8358b10c9b4f
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•