Closed Bug 908052 Opened 11 years ago Closed 11 years ago

cl.py path canonicalization doesn't fit well with make

Categories

(Firefox Build System :: General, defect)

All
Windows 7
defect
Not set
normal

Tracking

(firefox26 fixed, firefox-esr24 fixed)

RESOLVED FIXED
mozilla26
Tracking Status
firefox26 --- fixed
firefox-esr24 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

What os.path.normcase does is just to lowercase everything. This means that dependencies generated by cl.py, while they work to know if $file needs to be rebuilt if $header changed, doesn't make things chain up such that $header is rebuilt if $xpidl or whatever else changed. While this is not an immediate problem, it is a problem for future improvements such as bug 905973.
I'm not 100% sure about the caching thing. I've had different results with and without caching, sometimes with non-cached being faster. But that's in a VM with weird performance, so I can't tell for sure.
Attachment #793847 - Flags: review?(gps)
Blocks: 904743
Comment on attachment 793847 [details] [diff] [review] Use GetShortPathName/GetLongPathName to canonicalize paths for dependency files generated by cl.py Review of attachment 793847 [details] [diff] [review]: ----------------------------------------------------------------- Were you able to isolate the overhead of this? But if it makes dependencies proper, then I suppose it's a cost we need to pay.
Attachment #793847 - Flags: review?(gps) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: