Per TS 102.223 If the browser termination event is part of the event list (as set up by the last SET UP EVENT LIST command, see clause 6.4.16), then when the browser is terminated either by the user action or by an error, the terminal shall inform the UICC that this has occurred, by using the ENVELOPE (EVENT DOWNLOAD - browser termination) command as defined in clause 7.5.9.2.

Comment on attachment 798746 [details] [diff] [review] B2G STK: support "browser termination event" Envelope command Review of attachment 798746 [details] [diff] [review]: ----------------------------------------------------------------- It seems you forgot updating IDL. Please split your patches to Part 1: IDL. Part 2: implementation. Part 3: tests. ::: dom/system/gonk/ril_worker.js @@ +2635,5 @@ > + command.deviceId = { > + sourceId: STK_DEVICE_ID_ME, > + destinationId: STK_DEVICE_ID_SIM > + }; > + command.terminationCause=command.event.terminationCause; Where does terminationCause come from ?

(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #2) > Comment on attachment 798746 [details] [diff] [review] > B2G STK: support "browser termination event" Envelope command > > Review of attachment 798746 [details] [diff] [review]: > ----------------------------------------------------------------- > > It seems you forgot updating IDL. > > Please split your patches to > Part 1: IDL. > Part 2: implementation. > Part 3: tests. > > ::: dom/system/gonk/ril_worker.js > @@ +2635,5 @@ > > + command.deviceId = { > > + sourceId: STK_DEVICE_ID_ME, > > + destinationId: STK_DEVICE_ID_SIM > > + }; > > + command.terminationCause=command.event.terminationCause; > > Where does terminationCause come from ? Oh...yes I forget IDL part...

Try server result pass! https://tbpl.mozilla.org/?tree=Try&rev=90b402b69db8

Comment on attachment 799310 [details] [diff] [review] Part1: "Browser Termination" event IDL Review of attachment 799310 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/icc/interfaces/SimToolKit.idl @@ +634,5 @@ > + /** > + * This object shall contain the browser termination cause. > + * See TZ 102 223 8.51 > + */ > + unsigned short terminationCause; Please add the constants for cause in nsIDOMIccManager.

Comment on attachment 799312 [details] [diff] [review] Part2: "Browser Termination" event implement in RIL Review of attachment 799312 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/ril_worker.js @@ +2635,5 @@ > + command.deviceId = { > + sourceId: STK_DEVICE_ID_ME, > + destinationId: STK_DEVICE_ID_SIM > + }; > + command.terminationCause=command.event.terminationCause; nit, space between operators.

Comment on attachment 799334 [details] [diff] [review] Part1: "Browser Termination" event IDL. v3 Review of attachment 799334 [details] [diff] [review]: ----------------------------------------------------------------- Please update the comments for the terminationCause. Ask for a sr? to Jonas. ::: dom/icc/interfaces/SimToolKit.idl @@ +632,5 @@ > + unsigned short eventType; > + > + /** > + * This object shall contain the browser termination cause. > + * See TZ 102 223 8.51 The cause of this event, one of nsIDOMIccManager.STK_BROWSER_TERMINATION_CAUSE_USER and ...

Comment on attachment 799343 [details] [diff] [review] Part1: "Browser Termination" event IDL. v4 Review of attachment 799343 [details] [diff] [review]: ----------------------------------------------------------------- Over to Hsin-Yi

Comment on attachment 799343 [details] [diff] [review] Part1: "Browser Termination" event IDL. v4 Review of attachment 799343 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comments addressed. Thank you. ::: dom/icc/interfaces/SimToolKit.idl @@ +632,5 @@ > + unsigned short eventType; > + > + /** > + * This object shall contain the browser termination cause. > + * See TZ 102 223 8.51, It shall be one of following: nit: See TZ 102 223 8.51. <-- period here ;) ::: dom/icc/interfaces/nsIDOMIccManager.idl @@ +229,5 @@ > * @param command > * Command received from ICC. See MozStkCommand. > * @param response > * The response that will be sent to ICC. > * @see MozStkResponse for the detail of response. As a new MozStkBrowserTerminationEvent is created, we need to modify the comments "@param event" for sendStkEventDownload(), right?

According to reviewer's suggestion, modify comment in SimToolKit.idl and nsIDOMIccManager.idl

Please add r=me and run the try-server before landing these patches.

I do a little modification in Part3 since the change of ReadUint32()->ReadInt32(). Latest try-server result in below link: https://tbpl.mozilla.org/?tree=Try&rev=c9a8b5b21a48

I try to apply patch on current codebase and find we need to use "ReadInt32" instead of "ReadUint32" now. So here's the new patch with this change :)

Add reviewer = Yoshi into patch title.

Please rebase your patches, I got conflict when trying pushing them.

Rebase conflict file.

Rebase.

https://hg.mozilla.org/integration/b2g-inbound/rev/c44d0a4ab944 https://hg.mozilla.org/integration/b2g-inbound/rev/f5dbf24ff1f2 https://hg.mozilla.org/integration/b2g-inbound/rev/dcab3b214724

https://hg.mozilla.org/mozilla-central/rev/c44d0a4ab944 https://hg.mozilla.org/mozilla-central/rev/f5dbf24ff1f2 https://hg.mozilla.org/mozilla-central/rev/dcab3b214724

CC Anshul here.