Closed
Bug 908340
Opened 11 years ago
Closed 11 years ago
mach xpcshell-test shouldn't print test start lines
Categories
(Testing :: XPCShell Harness, defect)
Testing
XPCShell Harness
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: gps, Assigned: chmanchester)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
I think it is next to worthless for |mach xpcshell-test| to print the test start notification, especially when tests are executed concurrently.
In my ideal world, we'd have a progress bar and the only output would be from failing tests. I'll settle for simply killing the test start notification.
Chris: Can you tackle this quickly now that structured logging has landed?
Flags: needinfo?(cmanchester)
Assignee | ||
Comment 1•11 years ago
|
||
Yes. I'll take a look this afternoon.
Flags: needinfo?(cmanchester)
Assignee | ||
Comment 2•11 years ago
|
||
Unfortunately the "test start" message is output from Python, and my patch in
bug 890687 did not entail converting the Python logger to structured output,
so we're still working with strings here (I can look at converting XPCShell's
Python logger as a follow up; it might not take much).
So this is a little weird (what about other strings that might end with
"running test ..."?), but is effective for routine output.
Attachment #794402 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → cmanchester
Reporter | ||
Comment 3•11 years ago
|
||
Comment on attachment 794402 [details] [diff] [review]
Omit test start messages from mach xpcshell output;
A bit hacky, but sure.
Attachment #794402 -
Flags: review?(gps) → review+
Reporter | ||
Comment 4•11 years ago
|
||
Flags: in-testsuite-
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•