That makes this test work in b2g mochitest.

Comment on attachment 794254 [details] [diff] [review] 629535.diff Review of attachment 794254 [details] [diff] [review]: ----------------------------------------------------------------- I'll put this on tryserver later at some point, when I have to test some more patches.

Comment on attachment 794254 [details] [diff] [review] 629535.diff Review of attachment 794254 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/tests/mochitest/general/test_bug629535.html @@ +18,2 @@ > const dntPref = 'privacy.donottrackheader.enabled'; > const oldDNT = SpecialPowers.getBoolPref(dntPref); can we remove oldDNT?

Yes, will do.

I'm morphing this bug into adding some more tests that I'm rewriting, so they will (hopefully) work in b2g mochitest. I pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=6630fb3d2340

That last patch is with test_bug369306.html and test_idleapi_permissions.html rewritten, but still disabled in the b2g.json file, because they keep on failing. For test_sms_basics.html, I could use the 'remove' option from pushPermissions and I then noticed I made an error with the patch from bug 909012. When the permission doesn't exist, 'remove' causes a 'hang'. This patch fixes that.

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=bef0aecdd624

Ok, it turns out that test_idleapi_permissions.html fails when running it from inside the testrunner. It doesn't fail when running standalone. I removed the test_idleapi_permissions.html in this patch and I'll investigate that in a new bug. The tryserver is for the rest all green. I triggered some reruns for the chunks in b2g mochitest to make sure there is no intermittent orange.

Comment on attachment 797116 [details] [diff] [review] 908439_final.diff Review of attachment 797116 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/mobilemessage/tests/test_sms_basics.html @@ +23,5 @@ > } > > function checkSmsEnabled() { > // Bug 784617: WebSms is disabled on all platforms except Android for the moment. > + if (navigator.appVersion.indexOf("Android") == -1 && SpecialPowers.Services.appinfo.name != "B2G") { is there not a way to check for android in appinfo? @@ +90,5 @@ > +function test5() { > + if (!defaultEnabled) > + checkSmsDisabled(); > + else > + checkSmsEnabled(); this is repeated 4 times, could we make a function for this? ::: dom/tests/mochitest/bugs/test_bug265203.html @@ +97,5 @@ > if (gTestStarted) > return; > gTestStarted = true; > > + SpecialPowers.pushPrefEnv({"set": [["accessibility.browsewithcaret", true]]}, test0); this test case is cleaned up very nicely!

(In reply to Joel Maher (:jmaher) from comment #11) > Comment on attachment 797116 [details] [diff] [review] > is there not a way to check for android in appinfo? Yeah, there is. However, I'll do that in a different patch. There are more test files that do the same and I can change them at the same time. > this is repeated 4 times, could we make a function for this? I did that in this patch and named it "checkSmsDisabledOrEnabled".

(In reply to Martijn Wargers [:mwargers] (QA) from comment #10) > I removed the test_idleapi_permissions.html in this patch and I'll > investigate that in a new bug. I filed bug 910907 for it.