Closed
Bug 908483
Opened 11 years ago
Closed 11 years ago
Fix the remaining exact rooting hazards in jsd
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
This should take care of the 7 remaining hazards in js/jsd. Note, the treatment of JSPropertyDesc (e.g. removal) is not particularly elegant and not something I would do if jsd were not going away shortly. Fortunately, the long-term maintainablilty of jsd isn't really a concern, so I'm going with the solution that requires the least new code.
https://tbpl.mozilla.org/?tree=Try&rev=b19b23ef5d79
Attachment #794311 -
Flags: review?(jcoppeard)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 794311 [details] [diff] [review]
hazard_jsd-v0.diff
Review of attachment 794311 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #794311 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cdd8cacd0ad
Should be 7 JS Tree hazards fixed by this.
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•