Closed Bug 908536 Opened 11 years ago Closed 11 years ago

B2G STK: Support Proactive command Message for "CLOSE CHANNEL" "Receive Data" "Send Data"

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gwang, Assigned: gwang)

References

Details

Attachments

(3 files, 3 obsolete files)

Part1: STK-BIP CLOSE_CHANNEL, RECEIVE_DATA, SEND_DATA IDL v.2
(deleted), patch
allstars.chh
: review+
hsinyi
: review+
Details | Diff | Splinter Review
Part2: STK-BIP CLOSE_CHANNEL, RECEIVE_DATA, SEND_DATA handle in RIL v.2
(deleted), patch
allstars.chh
: review+
Details | Diff | Splinter Review
Part3: STK-BIP CLOSE_CHANNEL, RECEIVE_DATA, SEND_DATA xpcshell test v.2
(deleted), patch
allstars.chh
: review+
Details | Diff | Splinter Review
TS 102.223 6.4.28 This clause applies if class "e" is supported. This command requests the terminal to close the channel corresponding to the Channel identifier as indicated in the device identities.
Blocks: b2g-stk
Assignee: nobody → gwang
Summary: B2G STK: Support Proactive command "CLOSE CHANNEL" → B2G STK: Support Proactive command Message for "CLOSE CHANNEL" "Receive Data" "Send Data"
Component: DOM: Device Interfaces → RIL
Product: Core → Boot2Gecko
Version: Trunk → unspecified
Status: NEW → ASSIGNED
Depends on: 908535
Try server result: https://tbpl.mozilla.org/?tree=Try&rev=5c73c94f8fc7 Pass.
Attachment #818356 - Flags: review?(allstars.chh)
Attachment #818357 - Flags: review?(allstars.chh)
Attachment #818358 - Flags: review?(allstars.chh)
Can you update the titles in your patches first? Why are they still called '... Open Channel...'
Attachment #818356 - Attachment description: Part1: STK-BIP OPEN_CHANNEL, RECEIVE_DATA, SEND_DATA IDL v.1 → Part1: STK-BIP CLOSE_CHANNEL, RECEIVE_DATA, SEND_DATA IDL v.1
Attachment #818357 - Attachment description: Part2: STK-BIP OPEN_CHANNEL, RECEIVE_DATA, SEND_DATA handle in RIL v.1 → Part2: STK-BIP CLOSE_CHANNEL, RECEIVE_DATA, SEND_DATA handle in RIL v.1
Attachment #818357 - Attachment is obsolete: true
Attachment #818357 - Flags: review?(allstars.chh)
Attachment #818358 - Attachment is obsolete: true
Attachment #818358 - Flags: review?(allstars.chh)
Re-patch base on Bug908535.
Attachment #818356 - Attachment is obsolete: true
Attachment #818356 - Flags: review?(allstars.chh)
Change title and rebase.
Attachment #820762 - Flags: review?(allstars.chh)
Attachment #820763 - Flags: review?(allstars.chh)
Attachment #820764 - Flags: review?(allstars.chh)
Attachment #820762 - Flags: review?(htsai)
Attachment #820762 - Flags: review?(allstars.chh)
Attachment #820762 - Flags: review+
Attachment #820763 - Flags: review?(allstars.chh) → review+
Comment on attachment 820764 [details] [diff] [review] Part3: STK-BIP CLOSE_CHANNEL, RECEIVE_DATA, SEND_DATA xpcshell test v.2 Review of attachment 820764 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/tests/test_ril_worker_stk.js @@ +743,2 @@ > */ > add_test(function test_stk_proactive_command_open_channel() { update test name also.
Attachment #820764 - Flags: review?(allstars.chh) → review+
Attachment #820762 - Flags: review?(htsai) → review+
Keywords: checkin-needed
CCing Anshul for IDL change.
The constants here are wrong, file Bug 938466 to fix this.
Depends on: 938446
Depends on: 938466
No longer depends on: 938446
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: