I've spend some personal time of last month and rewrite the Zhuyin IME from scratch. Huge performance boost. I would like to land it to Gaia too. The code can be found at https://github.com/timdream/jszhuyin

Rudy, do you mind reviewing this, please? You could safely ignore the file removed and added as they are simply the JSZhuyin library and database. ./jszhuyin/jszhuyin.js have been rewritten to a iframe loader and message passer for the library, and there are some minor layout changes in layout.js.

Yeah, sure, put this in my review queue. I have to review Luke's pinyin first and other patches, but will try to review this soon. Thanks for you guys' effort to make us have Chinese input method!

Comment on attachment 794511 [details] Github: https://github.com/mozilla-b2g/gaia/pull/11709 Pull request updated.

Note that I need to update Glue code here because bug 906617 updated the internal API.

Comment on attachment 794511 [details] Github: https://github.com/mozilla-b2g/gaia/pull/11709 Pull request updated.

Comment on attachment 794511 [details] Github: https://github.com/mozilla-b2g/gaia/pull/11709 Pull request updated to adopt changes made in bug 884752. One should enable it in the build in order to test the patch here. GAIA_KEYBOARD_LAYOUTS=en,zh-Hant-Zhuyin make reset-gaia

Comment on attachment 794511 [details] Github: https://github.com/mozilla-b2g/gaia/pull/11709 First of all, really sorry to get to this review so late. I've done a review on jszhuyin.js while leaving the lib/* as is without going into details of it. The code looks quite good, except one thing about if we would release the memory by terminating the worker, since I guess the large database is loaded by the worker. Please flag me for the review again when this is done or if this is not an issue to worry about. Thanks for this nice work!

Comment on attachment 794511 [details] Github: https://github.com/mozilla-b2g/gaia/pull/11709 nit addressed on the original commit, with a WIP commit addresses the worker unloader you mentioned. I left it as another commit so you will be able to inspect it's non-trivial logic. Being able to load/unload the worker introduce yet two more states to the instance, before: init -a-> init:workerReady <-b-> uninit after: init <-c-> init:workerLoaded --d-> init:workerLoaded:workerReady <-e-> uninit The workerReady state is a sub-state only matters in sendMessage. The WIP patch implements method to go left and right on what denoted "c" above, and clean-up all variables in both init:workerLoaded and init:workerLoaded:workerReady state.

Comment on attachment 794511 [details] Github: https://github.com/mozilla-b2g/gaia/pull/11709 Looks good to me. I'll set feedback+ only since you said it is a WIP. Let me know when it is ready to review again.

Comment on attachment 794511 [details] Github: https://github.com/mozilla-b2g/gaia/pull/11709 r+, since this is ready as Tim said offline. Thanks, Tim.

Comment on attachment 794511 [details] Github: https://github.com/mozilla-b2g/gaia/pull/11709 Sorry for my late feedback. Actually it looks very well and I really look forward to input Trad. Chinese in FxOS.

master: https://github.com/mozilla-b2g/gaia/commit/8f8de161501b016a44f5d787fff70071b060dc3a I will attempt to uplift this patch to v1.2 to support community effort after a day or two.

Comment on attachment 794511 [details] Github: https://github.com/mozilla-b2g/gaia/pull/11709 [Approval Request Comment] [Bug caused by]: feature [User impact] if declined: Zhuyin IME will be left with it's broken state in v1.2, hamper the community-driven l10n effort. [Testing completed]: Yes, manually. [Risk to taking this patch] (and alternatives if risky): no likely risk because since bug 884752 Zhuyin will not be included in the build unless the user have select it in build config. [String changes made]: None, the localized name of keyboards have been removed

Uplifted 8f8de161501b016a44f5d787fff70071b060dc3a to: v1.2: f6bee023170f15d54ca8464c1797237dbca8a48b

Uplifted 8f8de161501b016a44f5d787fff70071b060dc3a to: v1.3 already had this commit