Closed
Bug 908837
Opened 11 years ago
Closed 11 years ago
Include a bit less stuff in binding implementation files
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
We can drop nsContentUtils and lots of binding headers we aren't actually using: we only need binding headers for some of our ancestor interfaces, not for all interfaces we have as args or whatnot.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #794822 -
Flags: review?(bugs)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 794822 [details] [diff] [review]
Include a bit less stuff in binding implementation files.
> for iface in interfaceDeps:
>- while iface.parent:
>+ if iface.parent:
>+ # We're going to need its prototype
> ancestors.append(iface.parent)
>- iface = iface.parent
>+ # And if we have an interface object, we'll need the
>+ # nearest ancestor with an interface object too.
please explain why
>+ if iface.hasInterfaceObject():
Shouldn't this be
if iface.hasInterfaceObject() and not iface.parent.hasInterfaceObject():
r+ assuming this compiles :)
Attachment #794822 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
> Shouldn't this be
> if iface.hasInterfaceObject() and not iface.parent.hasInterfaceObject():
Doesn't matter, since we're just adding to a set, so adding iface.parent twice isn't going to hurt anything.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → mozilla26
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•