Closed
Bug 908853
Opened 11 years ago
Closed 11 years ago
update talos.json to include new TART test
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
Attachments
(1 file)
(deleted),
patch
|
avih
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Comment on attachment 794829 [details] [diff] [review]
update talos.json to use new tart test (1.0)
Review of attachment 794829 [details] [diff] [review]:
-----------------------------------------------------------------
r=me to not block deployment which is very important to fx-team.
But we should address the concerns above at some stage.
::: testing/talos/talos.json
@@ +51,4 @@
> ]
> },
> "svgr": {
> + "tests": ["tsvgx", "tsvgr_opacity", "tart"],
I can't see how tart belongs in a group named "svgr". As far as I understand it was put here since it's the only group which doesn't use mozAfterPaint. To me that's too ad-hoc.
@@ +55,3 @@
> "talos_options": [
> "--filter",
> "ignore_first:5",
I also don't think tart needs to ignore first:5. I'd say 0 should work, but I'd take 1 if you insist.
Attachment #794829 -
Flags: review?(avihpit) → review+
Assignee | ||
Comment 3•11 years ago
|
||
inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/481ba42bbc8a
lets leave this open until we have a plan/bugs to address the two concerns.
Whiteboard: [leave open]
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
since we have fixed the filtering on the tests, this is running technically correct.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
You need to log in
before you can comment on or make changes to this bug.
Description
•