Closed Bug 908935 Opened 11 years ago Closed 11 years ago

Make test_networkstats_basics.html work again for b2g mochitest

Categories

(Core :: Networking, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: martijn.martijn, Unassigned)

References

()

Details

Attachments

(1 file)

Attached patch test_networkstats_basics.diff (deleted) — Splinter Review
The attached patch makes this file use pushPermissions, but there are also 3 failures currently when I run that test file in b2g mochitest emulator:
3 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_networkstats_basics.html | NetworkStatsManager should be prefixed
5 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_networkstats_basics.html | NetworkStats should be prefixed
7 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/network/tests/test_networkstats_basics.html | NetworkStatsData should be prefixed


This seems easy to fix. The failures are coming from this line:
 ok(("Moz" + aInterface) in window, aInterface + " should be prefixed");

Can you tell me if that test is still valid, or does it need adjusting?
Flags: needinfo?(acperez)
This test was added in bug 746069, btw.
I can only find mozNetworkStats as navigator property:
http://mxr.mozilla.org/mozilla-central/source/dom/network/src/NetworkStatsManager.manifest#9
QA Contact: martijn.martijn
This test is no longer valid, I modified it in bug 858005, which will land soon.
Flags: needinfo?(acperez)
Ok, thanks, I'll mark this one wfm then. Remember that if you want to have this test running in the b2g mochitest buildbots, then you have to remove it from the exclude list of b2g.json.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: