Closed
Bug 909159
Opened 11 years ago
Closed 11 years ago
UNKNOWN_XPCOM_ABI is undefined in AddonManager.jsm
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: Unfocused, Assigned: avp)
References
Details
(Whiteboard: [good first bug][mentor=bmcbride@mozilla.com][lang=js])
Attachments
(1 file)
|
(deleted),
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
Looks like we use UNKNOWN_XPCOM_ABI in AddonManager.jsm, but don't actually define it there....
It should be a const with a value of "unknownABI".
|
Assignee | |
Comment 1•11 years ago
|
||
Hi Blair,
I am uploading a patch to Bugzilla after quite sometime, hence took up this good first bug.
Thanks.
Assignee: nobody → abhishekp.bugzilla
Status: NEW → ASSIGNED
Attachment #810716 -
Flags: review?(bmcbride)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 810716 [details] [diff] [review]
bug-909159-fix.patch
Review of attachment 810716 [details] [diff] [review]:
-----------------------------------------------------------------
Perfect :)
Attachment #810716 -
Flags: review?(bmcbride) → review+
|
|
Reporter | |
Comment 3•11 years ago
|
||
Thanks Abhishek :) I just landed it on the fx-team branch, which gets merged into mozilla-central daily (the bug will get resolved as FIXED when that happens):
https://hg.mozilla.org/integration/fx-team/rev/72a469699ec3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•