Closed
Bug 909783
Opened 11 years ago
Closed 11 years ago
Change indentation of indicator.css to be less confusing
Categories
(Firefox :: Downloads Panel, defect)
Firefox
Downloads Panel
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Gijs, Assigned: manishearth)
References
Details
(Whiteboard: [Australis:M8][good first bug][lang=css][mentor=jaws][qa-])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
(In reply to Jared Wein [:jaws] from bug 890039 comment 5)
> @@ +41,5 @@
> > background-size: 12px;
> > }
> >
> > +#downloads-indicator:not([counter])
> > +#downloads-indicator-counter:-moz-lwtheme-brighttext {
>
> Placing this separator on two lines is confusing, at first I thought it was
> missing a comma! It appears that this is done elsewhere in the file though.
> Can you file a bug to place all of these selectors on the same line?
|
||
Comment 1•11 years ago
|
||
To fix this bug, you'll need to clone the repository at https://hg.mozilla.org/projects/ux/.
The file in question is located at browser/themes/osx/downloads/indicator.css.
Whiteboard: [Australis:M-] → [Australis:M-][good first bug][lang=css][mentor=jaws]
|
|
||
Comment 2•11 years ago
|
||
Manish, can you take this?
Assignee: nobody → manishsmail
Status: NEW → ASSIGNED
|
Assignee | |
Comment 3•11 years ago
|
||
Yep, this seems doable. Thanks!
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #796168 -
Flags: review?
|
Reporter | |
Comment 5•11 years ago
|
||
(In reply to Manish Goregaokar [:manishearth] from comment #4)
> Created attachment 796168 [details] [diff] [review]
> Patch 0.1
This is a good start! However, you'll probably want to fix the linux and windows files as well (they are very similar). :-)
|
|
Assignee | |
Comment 6•11 years ago
|
||
indicator.css seems pretty OK to me for the other two. No strange line breaks :)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #796168 -
Flags: review? → review?(jaws)
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 796168 [details] [diff] [review]
Patch 0.1
Review of attachment 796168 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, I don't see any issues with the windows or linux versions.
Looks good! Please upload a version of the patch file with the required header information. See https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F for more information.
Attachment #796168 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
Added headers.
Attachment #796168 -
Attachment is obsolete: true
Attachment #796199 -
Flags: review?(jaws)
|
|
||
Comment 9•11 years ago
|
||
Comment on attachment 796199 [details] [diff] [review]
Patch 0.2
Review of attachment 796199 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks! I'll check this in later today.
Attachment #796199 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 10•11 years ago
|
||
Ah, my first checkin (by proxy, but a checkin nevertheless)! Thanks!
|
|
||
Comment 11•11 years ago
|
||
Actually, your patch doesn't apply on the tip of the UX branch. https://hg.mozilla.org/projects/ux/rev/9ca205f212b7 looks to have bitrotted it.
I unbitrotted your patch and pushed it,
https://hg.mozilla.org/projects/ux/rev/fc1eb3b4cc36
Whiteboard: [Australis:M-][good first bug][lang=css][mentor=jaws] → [Australis:M8][good first bug][lang=css][mentor=jaws][fixed-in-ux]
|
|
Reporter | |
Comment 12•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][good first bug][lang=css][mentor=jaws][fixed-in-ux] → [Australis:M8][good first bug][lang=css][mentor=jaws]
Target Milestone: --- → Firefox 28
|
||
Updated•11 years ago
|
Whiteboard: [Australis:M8][good first bug][lang=css][mentor=jaws] → [Australis:M8][good first bug][lang=css][mentor=jaws][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•