It is important to know the date range we are looking at while viewing data. A first step is to print the range of dates used in presenting the data. We can get fancy to make this configurable later.

Hello Joel, I am interested in solving this bug. Can you tell me more about how to get started with this!?

Will it be enough to display min and max dates for all entries in ouija database? This can be done with quite simple query, so it's very easy to do. Or it's required to show only date range strictly related to displayed data? This is more complicated approach and should be done individually for every existing page. And how do you want to make it configurable? Should it be some input on each page or it should be some config file?

I think the intention was to show the min and max dates for the data currently presented on the page. E.g. the android2.2 page would show something like 2013-09-12 10:00:00 to 2013-09-19 10:00:00 underneath the title. This is your second approach. To customize it, you could add something like &startdate and &enddate parameters to the server query, and then add a UI to let the user specify this. It could default to 7 days. Thanks for looking at this.

Let's make it in three steps: 1. Show date range used for calculating displayed data 2. Add server-side ability to generate data for arbitrary date range 3. Add UI on Ouija pages that allows to change date range and recalculate data for selected timeframe This patch for the first step. I hope to submit another patch for server-side soon.

Comment on attachment 810833 [details] [diff] [review] 0001-show-date-range.patch Review of attachment 810833 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, pushed to https://github.com/dminor/ouija/commit/8197002cf00d2eed4f12ba4e63ba91f893a133bd

Yay! Dan, you mentioned that date range could default to 7 days, but from what date? I implemented logic as follows: 1. no endDate or startDate params, use [today - 7 days; today] date range; 2. no startDate param, use [endDate - 7 days; endDate] date range; 3. no enDate param, use [startDate; today] date range; 4. with startDate and endDate params, validate values and use them or replace with default values (as in p.1) if values are not valid. But it appears that some data (android2.2, for instance) will not be displayed, if startDate parameter is not supplied.

I'm so sorry, I put one curly bracket in javascript function too early, so part of the code that is responsible for hiding rows with no failures is not executed. Here is a fix for it.

Although, I fixed hiding rows on slaves page in patch submitted for https://bugzilla.mozilla.org/show_bug.cgi?id=909798

Comment on attachment 811499 [details] [diff] [review] 0002-hide-rows-with-no-failures.patch Review of attachment 811499 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!

Added ability to select date range for slave failures page.

Comment on attachment 814005 [details] [diff] [review] 0003-allow-select-date-range-for-slaves-report.patch Review of attachment 814005 [details] [diff] [review]: ----------------------------------------------------------------- Looks great, thanks!

Great! this should be done for all pages, right?

yes, if it makes sense.