Closed
Bug 909938
Opened 11 years ago
Closed 11 years ago
Only display Settings UI for wifi/cell tower reporting on non-release builds
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox24 unaffected, firefox25+ verified, firefox26+ fixed)
RESOLVED
FIXED
Firefox 26
| Tracking | Status | |
|---|---|---|
| firefox24 | --- | unaffected |
| firefox25 | + | verified |
| firefox26 | + | fixed |
People
(Reporter: liuche, Assigned: liuche)
Details
Attachments
(2 files)
|
(deleted),
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
gbrown
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Filing this because bug 903535 doesn't really cover Settings UI. Moving patch and r+ over.
Try build: https://tbpl.mozilla.org/?tree=Try&rev=f70b1c3b2820
Attachment #796264 -
Flags: review+
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → liuche
|
|
Assignee | |
Updated•11 years ago
|
Summary: Only display Settings UI for wifi/cell tower UI on non-release builds → Only display Settings UI for wifi/cell tower reporting on non-release builds
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•11 years ago
|
tracking-firefox25:
--- → ?
|
|
Assignee | |
Comment 3•11 years ago
|
||
Aurora patch for not building wifi/cell tower reporting UI for release builds.
Try: https://tbpl.mozilla.org/?tree=Try&rev=fbcda47b0335
Attachment #799190 -
Flags: review?(gbrown)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 799190 [details] [diff] [review]
Aurora patch: do not build wifi for release builds v1
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Decision to restrict wifi/cell tower datareporting to non-release builds
User impact if declined: wifi/cell tower UI will be visible in release builds
Testing completed (on m-c, etc.): all green aurora try run (https://tbpl.mozilla.org/?tree=Try&rev=fbcda47b0335)
Risk to taking this patch (and alternatives if risky): low, adds conditional UI and updates a test
String or IDL/UUID changes made by this patch: none
Attachment #799190 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•11 years ago
|
status-firefox24:
--- → unaffected
tracking-firefox26:
--- → +
|
||
Updated•11 years ago
|
Attachment #799190 -
Flags: review?(gbrown) → review+
|
|
||
Updated•11 years ago
|
Attachment #799190 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 5•11 years ago
|
||
Verified as fixed on Samsung Galaxy R (Android 2.3.4), on Firefox RC 25 build 3.
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•