Closed Bug 910351 Opened 11 years ago Closed 11 years ago

[e.me][feature] Apply full bg image new design

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sonmarce, Assigned: evyatar)

References

Details

Attachments

(2 files)

Full screen redesign
(deleted), image/png
Details
Patch - redirect to github PR
(deleted), text/html
crdlc
: review+
Details
No description provided.
Blocks: 1.3-e.me
Additional information: Currently full bgimage mode (swipe results down till they disappear) displays a footer with info. 1. Attached is the new design. 2. Clicking the "wallpaper" pops up an alert for saving the image as wallpaper.
Assignee: nobody → evyatar
Status: NEW → ASSIGNED
Attached file Patch - redirect to github PR (deleted) —
Attachment #810574 - Flags: review?(crdlc)
r+ for the attachment ;)
Addressed comments on GH and Travis passed. Cristian, are we good to land (no r+ yet)?
Flags: needinfo?(crdlc)
It is not r+ because I am not agree with the markup See https://github.com/mozilla-b2g/gaia/pull/12475#issuecomment-25172408
Flags: needinfo?(crdlc)
I don't want to see a separator as image, please review with detail the header bb
as far as I can tell the BB also uses an image... am I looking at the wrong place? https://github.com/mozilla-b2g/gaia/blob/master/shared/style/headers.css#L239
Sorry, I didn't see you comment, so r+
Attachment #810574 - Flags: review?(crdlc) → review+
great! thanks, merged into master ced4f2a44e81a61405d45f5a8298f4d5d1870162 https://github.com/mozilla-b2g/gaia/commit/ced4f2a44e81a61405d45f5a8298f4d5d1870162
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: --- → koi?
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: